Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update import tests #1905

Open
dstillman opened this issue Mar 8, 2019 · 1 comment · May be fixed by #1963
Open

Update import tests #1905

dstillman opened this issue Mar 8, 2019 · 1 comment · May be fixed by #1963

Comments

@dstillman
Copy link
Member

Now that we're using import tests in translation-server CI, we should update tests for import translators so that they pass. We mostly just appear to be saving many more fields now than when the tests were generated, and there's some additional whitespace normalization in abstracts.

(At least, I'm assuming the test failures happen in Scaffold too and translation-server isn't somehow saving many more fields.)

zuphilip added a commit to zuphilip/translators that referenced this issue Jun 16, 2019
@zuphilip zuphilip linked a pull request Jun 16, 2019 that will close this issue
@zuphilip
Copy link
Contributor

Okay, I updated some of them in #1963. Let me second that I would appreciate when test cases are checked language-independent, because I otherwise have to delete the changes to German date formats which you will not see, see also zotero/scaffold#21

The test cases for Medline show duplicate tags, which we will not be saved in Zotero. Is there some step missing for testing? Probably related to zotero/scaffold#47

The itemIDs in the RDF-translator are not constant in different runs and therefore cannot easily been fixed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging a pull request may close this issue.

2 participants