Fixed item list icon not updated when main attachment is added/removed (

#801)
zotero · Nov 6, 2023 · 251b356 · 251b356
1 parent cab5523
commit 251b356
Show file tree

Hide file tree

Showing 5 changed files with 7 additions and 3 deletions.
diff --git a/Zotero.xcodeproj/project.pbxproj b/Zotero.xcodeproj/project.pbxproj
@@ -6082,7 +6082,7 @@
 			repositoryURL = "https://github.com/realm/realm-cocoa";
 			requirement = {
 				kind = exactVersion;
-				version = 10.43.1;
+				version = 10.44.0;
 			};
 		};
 		B35E4B8B25248B3C000EA134 /* XCRemoteSwiftPackageReference "RxSwift" */ = {

diff --git a/Zotero.xcodeproj/project.xcworkspace/xcshareddata/swiftpm/Package.resolved b/Zotero.xcodeproj/project.xcworkspace/xcshareddata/swiftpm/Package.resolved
@@ -95,8 +95,8 @@
       "kind" : "remoteSourceControl",
       "location" : "https://github.com/realm/realm-cocoa",
       "state" : {
-        "revision" : "a3da8c91ee44c7610d4b1100bd3079ddca26ab84",
-        "version" : "10.43.1"
+        "revision" : "fd199ce07edb4db69e862f74151b95602aad3b43",
+        "version" : "10.44.0"
       }
     },
     {

diff --git a/Zotero/Controllers/Database/Requests/MoveItemsToParentDbRequest.swift b/Zotero/Controllers/Database/Requests/MoveItemsToParentDbRequest.swift
@@ -41,6 +41,7 @@ struct MoveItemsToParentDbRequest: DbRequest {
         }
 
         // Update the parent item, so that it's updated in the item list to show attachment/note marker
+        parent.baseTitle = parent.baseTitle
         parent.changeType = .user
     }
 }
diff --git a/Zotero/Controllers/Database/Requests/RemoveItemFromParentDbRequest.swift b/Zotero/Controllers/Database/Requests/RemoveItemFromParentDbRequest.swift
@@ -19,6 +19,7 @@ struct RemoveItemFromParentDbRequest: DbRequest {
     func process(in database: Realm) throws {
         guard let item = database.objects(RItem.self).filter(.key(self.key, in: self.libraryId)).first, item.parent != nil else { return }
         // Update the parent item, so that it's updated in the item list to hide attachment/note marker
+        item.parent?.baseTitle = item.parent?.baseTitle ?? ""
         item.parent?.changeType = .user
         item.parent = nil
         item.changes.append(RObjectChange.create(changes: RItemChanges.parent))

diff --git a/Zotero/Scenes/Detail/Items/ViewModels/ItemsActionHandler.swift b/Zotero/Scenes/Detail/Items/ViewModels/ItemsActionHandler.swift
@@ -716,6 +716,8 @@ struct ItemsActionHandler: ViewModelActionHandler, BackgroundDbProcessingActionH
                     if state.selectedItems.remove(key) != nil {
                         state.changes.insert(.selection)
                     }
+                    state.itemAccessories[key] = nil
+                    state.itemTitles[key] = nil
                 }
             }