Auto release computed PNG data after caching (#1026)

zotero · Nov 18, 2024 · 5ab1e85 · 5ab1e85
1 parent 5de61df
commit 5ab1e85
Show file tree

Hide file tree

Showing 2 changed files with 21 additions and 17 deletions.
diff --git a/Zotero/Controllers/AnnotationPreviewController.swift b/Zotero/Controllers/AnnotationPreviewController.swift
@@ -306,15 +306,17 @@ extension AnnotationPreviewController {
     }
 
     private func cache(image: UIImage, key: String, pdfKey: String, libraryId: LibraryIdentifier, isDark: Bool) {
-        guard let data = image.pngData() else {
-            DDLogError("AnnotationPreviewController: can't create data from image")
-            return
-        }
-
-        do {
-            try fileStorage.write(data, to: Files.annotationPreview(annotationKey: key, pdfKey: pdfKey, libraryId: libraryId, isDark: isDark), options: .atomicWrite)
-        } catch let error {
-            DDLogError("AnnotationPreviewController: can't store preview - \(error)")
+        autoreleasepool {
+            guard let data = image.pngData() else {
+                DDLogError("AnnotationPreviewController: can't create data from image")
+                return
+            }
+
+            do {
+                try fileStorage.write(data, to: Files.annotationPreview(annotationKey: key, pdfKey: pdfKey, libraryId: libraryId, isDark: isDark), options: .atomicWrite)
+            } catch let error {
+                DDLogError("AnnotationPreviewController: can't store preview - \(error)")
+            }
         }
     }
 }
diff --git a/Zotero/Controllers/PDFThumbnailController.swift b/Zotero/Controllers/PDFThumbnailController.swift
@@ -149,14 +149,16 @@ extension PDFThumbnailController {
         }
 
         func cache(image: UIImage, page: UInt, key: String, libraryId: LibraryIdentifier, isDark: Bool) {
-            guard let data = image.pngData() else {
-                DDLogError("PdfThumbnailController: can't create data from image")
-                return
-            }
-            do {
-                try fileStorage.write(data, to: Files.pageThumbnail(pageIndex: page, key: key, libraryId: libraryId, isDark: isDark), options: .atomicWrite)
-            } catch let error {
-                DDLogError("PdfThumbnailController: can't store preview - \(error)")
+            autoreleasepool {
+                guard let data = image.pngData() else {
+                    DDLogError("PdfThumbnailController: can't create data from image")
+                    return
+                }
+                do {
+                    try fileStorage.write(data, to: Files.pageThumbnail(pageIndex: page, key: key, libraryId: libraryId, isDark: isDark), options: .atomicWrite)
+                } catch let error {
+                    DDLogError("PdfThumbnailController: can't store preview - \(error)")
+                }
             }
         }
     }