Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed firefox share extension #817

Merged
merged 2 commits into from
Dec 8, 2023
Merged

Conversation

michalrentka
Copy link
Contributor

@michalrentka michalrentka commented Dec 8, 2023

Firefox sends multiple NSItemProviders and we always took the first. In case of Firefox, the first one was plaintext and second one was web. Web contains more info than plaintext, so I order them based on priority so that we always get most useful info for translation.

Fixes #816

@michalrentka michalrentka requested a review from mvasilak December 8, 2023 10:12
Copy link
Contributor

@mvasilak mvasilak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

1 minor change

ZShare/ViewModels/ExtensionViewModel.swift Outdated Show resolved Hide resolved
@michalrentka michalrentka merged commit 96b2484 into zotero:master Dec 8, 2023
1 check passed
@michalrentka michalrentka deleted the firefoxfix branch December 8, 2023 13:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

Saving from Firefox app not working
2 participants