Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Upgrade euneus to 2.3 - add OTP27 to tests #12

Merged
merged 6 commits into from
Aug 28, 2024
Merged

Upgrade euneus to 2.3 - add OTP27 to tests #12

merged 6 commits into from
Aug 28, 2024

Conversation

mworrell
Copy link
Member

@mworrell mworrell commented Aug 28, 2024 •
edited
Loading

TODO:

  • Fix error handler (skipping unknown values)

@mworrell
Copy link
Member Author

mworrell commented Aug 28, 2024 •
edited
Loading

@williamthome do you know of a method to not include the json-polyfill for OTP27+ ?

williamthome
williamthome suggested changes Aug 28, 2024
View reviewed changes
rebar.config Outdated Show resolved Hide resolved
@mworrell mworrell requested a review from williamthome August 28, 2024 13:41
williamthome
williamthome approved these changes Aug 28, 2024
View reviewed changes
Copy link
Contributor

@williamthome williamthome left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM o/

@mworrell mworrell merged commit c42bf8b into master Aug 28, 2024
4 checks passed
@mworrell mworrell deleted the upgrade-euneus branch August 28, 2024 13:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@williamthome williamthome williamthome approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mworrell @williamthome