Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Handle message_embed website previews #1016

Open
gnprice opened this issue Oct 21, 2024 · 0 comments · May be fixed by #1049
Open

Handle message_embed website previews #1016

gnprice opened this issue Oct 21, 2024 · 0 comments · May be fixed by #1049
Assignees
Labels
a-content Parsing and rendering Zulip HTML content, notably message contents
Milestone

Comments

@gnprice
Copy link
Member

gnprice commented Oct 21, 2024

I.e., this Zulip feature:
https://zulip.com/help/image-video-and-website-previews#configure-whether-website-previews-are-shown
which we've also called "inline URL preview".

The HTML elements for these look like <div class="message_embed">. Example message here:
https://chat.zulip.org/#narrow/stream/101-design/topic/auto-linkification.20of.20issues/near/193181

On chat.zulip.org these are scarce because it's a realm-level setting which we turned off after a brief period enabled, so it's easy for us to forget about this feature. But on realms that have the setting turned on, they'll naturally be much more common.

These appeared in the results of the survey #917 / #190 of unimplemented content features. Thanks to @andersk for pointing out (#965 (comment)) that this is a current feature.

@gnprice gnprice added the a-content Parsing and rendering Zulip HTML content, notably message contents label Oct 21, 2024
@gnprice gnprice added this to the Launch milestone Oct 21, 2024
@rajveermalviya rajveermalviya self-assigned this Nov 18, 2024
rajveermalviya added a commit to rajveermalviya/zulip-flutter that referenced this issue Nov 18, 2024
@rajveermalviya rajveermalviya linked a pull request Nov 18, 2024 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
a-content Parsing and rendering Zulip HTML content, notably message contents
Projects
Status: No status
Development

Successfully merging a pull request may close this issue.

2 participants