Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Follow /near/ links through message moves #683

Open
gnprice opened this issue May 16, 2024 · 0 comments
Open

Follow /near/ links through message moves #683

gnprice opened this issue May 16, 2024 · 0 comments
Assignees
Labels
a-api Implementing specific parts of the Zulip server API a-msglist The message-list screen, except what's label:a-content

Comments

@gnprice
Copy link
Member

gnprice commented May 16, 2024

When a Zulip narrow link has a /near/ operator in it, this means two things:

(A) Start the view around the given message, rather than at the user's first unread.

(B) If the message has moved — for example if the topic was renamed or resolved or split up — then find where the message is now, and go to that conversation instead of the one specified by any channel/stream or topic operators in the link.

Part A is #82. This issue is for part B.

The corresponding zulip-mobile issue, back in 2022 (when /near/ links gained that meaning in the first place), was zulip/zulip-mobile#5306 .

This issue is independent of #82, and we can do them in either order. (Web had part A without B for many years; zulip-mobile has part B but still lacks part A.)


(Previously, this issue also tracked following /with/ links ("topic permalinks") through message moves. That's been split out to #1028, but at least one commit in main, ebb41b6, points to this issue as tracking the /with/ feature.)

@gnprice gnprice added a-msglist The message-list screen, except what's label:a-content a-api Implementing specific parts of the Zulip server API labels May 16, 2024
@gnprice gnprice added this to the Beta 3: Summer 2024 milestone May 16, 2024
sm-sayedi added a commit to sm-sayedi/zulip-flutter that referenced this issue Jun 11, 2024
These links (`/with/NNNN`) are just accepted and ignored in this PR,
they will be interpreted in zulip#683.

Fixes: zulip#684
sm-sayedi added a commit to sm-sayedi/zulip-flutter that referenced this issue Jun 11, 2024
These links (`/with/NNNN`) are just accepted and ignored in this PR,
they will be interpreted in zulip#683.

Fixes: zulip#684
sm-sayedi added a commit to sm-sayedi/zulip-flutter that referenced this issue Jun 11, 2024
These links (`/with/NNNN`) are just accepted and ignored in this PR,
they will be interpreted in zulip#683.

Fixes: zulip#684
gnprice pushed a commit to sm-sayedi/zulip-flutter that referenced this issue Jun 13, 2024
This `with` operator (as in `/with/NNNN`) is just accepted and
ignored as of this change.  Interpreting them is zulip#683.

Fixes: zulip#684
@gnprice gnprice changed the title Follow /near/ links through message moves Follow /with/ and /near/ links through message moves Jun 13, 2024
@gnprice gnprice modified the milestones: Beta 3: Summer 2024, Launch Sep 10, 2024
@chrisbobbe chrisbobbe self-assigned this Sep 20, 2024
@chrisbobbe chrisbobbe changed the title Follow /with/ and /near/ links through message moves Follow /near/ links through message moves Oct 25, 2024
@gnprice gnprice modified the milestones: M5: Launch, M6: Post-launch Nov 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
a-api Implementing specific parts of the Zulip server API a-msglist The message-list screen, except what's label:a-content
Projects
Status: No status
Development

No branches or pull requests

2 participants