Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Exclude unknown users from lists of users (for limited guests) #5808

Open
gnprice opened this issue Dec 22, 2023 · 2 comments
Open

Exclude unknown users from lists of users (for limited guests) #5808

gnprice opened this issue Dec 22, 2023 · 2 comments
Labels
P1 high-priority webapp parity Features that exist in the webapp that we need to port to mobile. We aren't aiming for full parity.

Comments

@gnprice
Copy link
Member

gnprice commented Dec 22, 2023

This is the remaining item from #5787, for comfortably supporting Zulip Server 8's new "limited guests" feature.

We should pass the new user_list_incomplete client capability. That should solve this symptom:

  • Lists of users (the "user list" component found in several places including "New DM", and the autocomplete for @-mentions) include the unknown users and shouldn't. We can fix that once a planned server feature is added.

See details in discussion at #5787.
@gnprice gnprice added P1 high-priority webapp parity Features that exist in the webapp that we need to port to mobile. We aren't aiming for full parity. labels Dec 22, 2023
@gnprice gnprice mentioned this issue Dec 22, 2023
Closed
@chrisbobbe chrisbobbe mentioned this issue Dec 22, 2023
Merged
chrisbobbe added a commit to chrisbobbe/zulip-mobile that referenced this issue Dec 22, 2023
@chrisbobbe
CustomProfileFields: Use styled UserItem for (unknown user)
690c1ff 
Since zulip#5790 last month, UserItem has been prepared to gracefully
handle users we don't know about. Use that, instead of
special-casing with a plain ZulipTextIntl, which we'd been doing
since 2022-06 (0a10831) when CustomProfileFields was added.

The change won't be visible unless a given user object is actually
absent; that'll start happening when we do zulip#5808.

See screenshots:
  zulip#5809 (comment)
chrisbobbe added a commit to chrisbobbe/zulip-mobile that referenced this issue Jan 4, 2024
@chrisbobbe
CustomProfileFields: Use styled UserItem for (unknown user)
930d9d7 
Since zulip#5790 last month, UserItem has been prepared to gracefully
handle users we don't know about. Use that, instead of
special-casing with a plain ZulipTextIntl, which we'd been doing
since 2022-06 (0a10831) when CustomProfileFields was added.

The change won't be visible unless a given user object is actually
absent; that'll start happening when we do zulip#5808.

See screenshots:
  zulip#5809 (comment)
chrisbobbe added a commit to chrisbobbe/zulip-mobile that referenced this issue Jan 4, 2024
@chrisbobbe
CustomProfileFields: Use styled UserItem for (unknown user)
6826517 
Since zulip#5790 last month, UserItem has been prepared to gracefully
handle users we don't know about. Use that, instead of
special-casing with a plain ZulipTextIntl, which we'd been doing
since 2022-06 (0a10831) when CustomProfileFields was added.

The change won't be visible unless a given user object is actually
absent; that'll start happening when we do zulip#5808.

See screenshots:
  zulip#5809 (comment)
chrisbobbe added a commit to chrisbobbe/zulip-mobile that referenced this issue Jan 5, 2024
@chrisbobbe
CustomProfileFields: Use styled UserItem for (unknown user)
2273d56 
Since zulip#5790 last month, UserItem has been prepared to gracefully
handle users we don't know about. Use that, instead of
special-casing with a plain ZulipTextIntl, which we'd been doing
since 2022-06 (0a10831) when CustomProfileFields was added.

The change won't be visible unless a given user object is actually
absent; that'll start happening when we do zulip#5808.

See screenshots:
  zulip#5809 (comment)
@Sadaf-A

This comment was marked as duplicate.

Sign in to view
1 similar comment
@Sadaf-A

This comment was marked as duplicate.

Sign in to view
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
P1 high-priority webapp parity Features that exist in the webapp that we need to port to mobile. We aren't aiming for full parity.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@gnprice @Sadaf-A