Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Check / fix table border color in dark mode #5871

Open
alya opened this issue Jun 4, 2024 · 5 comments
Open

Check / fix table border color in dark mode #5871

alya opened this issue Jun 4, 2024 · 5 comments
Labels
webapp parity Features that exist in the webapp that we need to port to mobile. We aren't aiming for full parity.

Comments

@alya
Copy link
Collaborator

alya commented Jun 4, 2024

As a follow-up to zulip/zulip#29856, we should see if it's worth tweaking the table border color in dark theme in the mobile app.

@alya alya added webapp parity Features that exist in the webapp that we need to port to mobile. We aren't aiming for full parity. server release goal Things we should try to coordinate with a major Zulip Server release. labels Jun 4, 2024
@gnprice
Copy link
Member

gnprice commented Jun 4, 2024

Implementation notes:

The first step here is to see if the issue reproduces in mobile. If tables in dark mode already look fine and don't have this issue, then we're done.

If the issue does reproduce, then we should be able to fix it by just copying whatever CSS change is made to fix it in web.

@alya
Copy link
Collaborator Author

alya commented Jun 12, 2024

The webapp issue has been resolved in zulip/zulip#29859.

@gnprice
Copy link
Member

gnprice commented Jun 12, 2024

Cool, thanks for the update.

It looks like the key change was in this commit: zulip/zulip@8a9fb04
and changed the border color from hsl(0deg 0% 0% / 20%) to hsl(0deg 0% 100% / 20%).

It kind of sounds like this might have been a regression caused in the first place by some other changes — it looks like what happened is that some CSS that was meant for a different part of the UI was too broad and consequently applied also to tables in Markdown content. So that suggests the issue might not exist in mobile. We'll find out as the first step in this issue, as mentioned above.

@alya
Copy link
Collaborator Author

alya commented Jul 10, 2024

I'm not sure this is a priority for the legacy app? In any case, removing the release goal label, as it's not specifically timely for 9.0.

@alya alya removed the server release goal Things we should try to coordinate with a major Zulip Server release. label Jul 10, 2024
@gnprice
Copy link
Member

gnprice commented Jul 10, 2024

Yeah — I think as long as this isn't something we feel we're likely to highlight in the 9.0 announcement (and I suspect it isn't), it isn't a priority for the legacy app.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
webapp parity Features that exist in the webapp that we need to port to mobile. We aren't aiming for full parity.
Projects
Status: No status
Development

No branches or pull requests

2 participants