Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Button Label Inconsistent with naming of Channels and Streams #5898

Open
Joshy-R opened this issue Oct 8, 2024 · 3 comments
Open

Button Label Inconsistent with naming of Channels and Streams #5898

Joshy-R opened this issue Oct 8, 2024 · 3 comments
Labels
a-i18n Translation, localization, internationalization

Comments

@Joshy-R
Copy link

Joshy-R commented Oct 8, 2024

On Mobile Devices with large Screens, the labels of the buttons on the bottom show their label. The label for the second button shows 'Streams', although for the new Zulip version, this should be renamed to 'Channels'.
Other labels throughout the app show the correct text (e.g. the title of the channels section has the text 'Channels').

This issue may not be relevant for the mobile app, as the new app is already in beta.
Feel free to close this issue if this app version is soon EOL.

@gnprice
Copy link
Member

gnprice commented Oct 8, 2024

Thanks for the report.

It looks like the underlying issue here is that those tab labels aren't marked for translation. If they were, then the general mechanism we applied (in #5830) for the stream/channel rename would have caught the string "Streams" and caused it to say "Channels" when you're using a recent server, just like in other places in the app.

I think this is indeed an issue we won't fix within this legacy app. I'll leave it open because it is a genuine issue in this app; but it'll be one of the issues we leave unfixed when we launch the new app and archive this app's issue tracker.

@gnprice gnprice added the a-i18n Translation, localization, internationalization label Oct 8, 2024
@mayankdhangar2408

This comment was marked as spam.

@gnprice

This comment was marked as off-topic.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
a-i18n Translation, localization, internationalization
Projects
None yet
Development

No branches or pull requests

3 participants