Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow html Comments when using html-min #135

Open
godofdream opened this issue Jun 15, 2020 · 3 comments
Open

Allow html Comments when using html-min #135

godofdream opened this issue Jun 15, 2020 · 3 comments
Labels
bug Something isn't working html5-parser At html5 parser

Comments

@godofdream
Copy link

godofdream commented Jun 15, 2020

I'm getting a yarte (feature=["html-min"]) error for

<!--[if lt IE 9]>
<script src="//html5shim.googlecode.com/svn/trunk/html5.js"></script>
<![endif]-->

obviously this html comment is more than a simple html comment and should therefore work.
error I'm getting:
"No use html comment, use yarte comments instead"

Edit: Mentioning html-min feature

@zzau13
Copy link
Owner

zzau13 commented Jun 15, 2020

Html5 parser is work is progress. Use without html minification.

I will consider these cases.
Thanks for reporting, I leave it open to remember.

@zzau13 zzau13 added the bug Something isn't working label Jun 15, 2020
@godofdream
Copy link
Author

do you plan to use html5ever or do you want to fork it?

@godofdream godofdream changed the title Allow html Comments Allow html Comments when using html-min Jun 16, 2020
@zzau13
Copy link
Owner

zzau13 commented Jun 16, 2020

I refork it 😄. I need the clonable status of the tokenizer. And modify how it treats certain elements such as html attributes. Remove certain abstractions and dock it to a DOM.

@zzau13 zzau13 added the html5-parser At html5 parser label Jul 9, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working html5-parser At html5 parser
Projects
None yet
Development

No branches or pull requests

2 participants