Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

change default FORCE_LOWER to true #32

Open
oldboys92 opened this issue Feb 1, 2024 · 0 comments
Open

change default FORCE_LOWER to true #32

oldboys92 opened this issue Feb 1, 2024 · 0 comments

Comments

@oldboys92
Copy link

The developer documentation from gravatar.com states:

To ensure a consistent and accurate hash, the following steps should be taken to create a hash:

  1. Trim leading and trailing whitespace from an email address
  2. Force all characters to lower-case
  3. hash the final string with SHA256

Current implementation has a default value for FORCE_LOWER of False. This results in a wrong hash value for emails which start or are complete in upper case. I think the default should follow gravatar.com recommendations and force all characters of an email address to lower-case.

oldboys92 added a commit to oldboys92/Flask-Gravatar that referenced this issue Feb 1, 2024
Fix to change default for `FORCE_LOWER` to `True` zzzsochi#32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant