Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[move] enhance vouch system [breaking] #303

Merged
merged 14 commits into from
Aug 13, 2024

Conversation

soaresa
Copy link
Contributor

@soaresa soaresa commented Aug 8, 2024

This PR implements the enhancements to the voucher system as outlined in issue #298.

Objective:
The update aims to improve security, enhance reliability, and ensure greater active participation of validators in the social consensus. These changes are designed to prevent Sybil attacks, manage validator eligibility more effectively, and maintain overall network stability.

Key Updates:

  • Data Migrations: Introduced new resources: ReceivedVouches and GivenVouches, and removed the MyVouches resource to streamline the voucher tracking process.

  • Migrations Module: Developed a new Migrations module to manage and centralize data migration execution. This module records migration history, including the migration number, epoch, and description. All migrations will be executed at the start of each epoch boundary.

These improvements aim to create a more secure and reliable framework for tracking and managing vouches, thereby supporting the network's stability and integrity.

Move Test Coverage:

Test Coverage Overall Score % #Tests
Before 70.08 349
After 71.36 376
Diff. 1.04 27

Move Test Coverage Score per Module:

Module Name Before After Diff
vouch_migration - 100 100
migrations* - 82.3 82.3
vouch 58.68 97.29 38.61
fee_maker 78.6 88.48 9.88
transaction_fee 70.81 74.59 3.78
globals 38.89 42.22 3.33
ancestry 85.02 87.62 2.6
slow_wallet 68.68 69.61 0.93
ol_account 72.11 72.79 0.68
proof_of_fee 88.25 88.51 0.26
epoch_boundary 90.83 91.03 0.2

*new migrations module will have 100% test coverage in the very next migration.

@soaresa soaresa changed the title Breaking/enhance vouch system [move] Enhance Vouch System [breaking] Aug 9, 2024
@soaresa soaresa changed the title [move] Enhance Vouch System [breaking] [move] enhance vouch system [breaking] Aug 12, 2024
@soaresa soaresa force-pushed the breaking/enhance_vouch_system branch from 34905f9 to a379f5f Compare August 12, 2024 18:19
@soaresa soaresa marked this pull request as ready for review August 12, 2024 19:11
@soaresa soaresa requested a review from 0o-de-lally August 12, 2024 19:11
@0o-de-lally 0o-de-lally requested a review from sasuke0787 August 13, 2024 17:23
Copy link
Contributor

@0o-de-lally 0o-de-lally left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, reviewed prior with @soaresa

@soaresa soaresa force-pushed the breaking/enhance_vouch_system branch from a379f5f to 223ce8e Compare August 13, 2024 17:49
@soaresa soaresa merged commit 693657f into 0LNetworkCommunity:main Aug 13, 2024
13 checks passed
0o-de-lally pushed a commit to 0o-de-lally/libra-framework that referenced this pull request Aug 16, 2024
0o-de-lally pushed a commit to 0o-de-lally/libra-framework that referenced this pull request Aug 16, 2024
0o-de-lally pushed a commit to 0o-de-lally/libra-framework that referenced this pull request Aug 16, 2024
0o-de-lally pushed a commit to 0o-de-lally/libra-framework that referenced this pull request Aug 16, 2024
0o-de-lally pushed a commit to 0o-de-lally/libra-framework that referenced this pull request Aug 16, 2024
0o-de-lally pushed a commit to 0o-de-lally/libra-framework that referenced this pull request Aug 17, 2024
0o-de-lally pushed a commit to 0o-de-lally/libra-framework that referenced this pull request Aug 17, 2024
0o-de-lally pushed a commit to 0o-de-lally/libra-framework that referenced this pull request Aug 17, 2024
0o-de-lally pushed a commit to 0o-de-lally/libra-framework that referenced this pull request Aug 17, 2024
0o-de-lally pushed a commit to 0o-de-lally/libra-framework that referenced this pull request Aug 17, 2024
0o-de-lally pushed a commit to 0o-de-lally/libra-framework that referenced this pull request Aug 17, 2024
0o-de-lally pushed a commit to 0o-de-lally/libra-framework that referenced this pull request Aug 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants