-
Notifications
You must be signed in to change notification settings - Fork 6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: Convert to Deno #17
Open
ebebbington
wants to merge
42
commits into
0kku:master
Choose a base branch
from
ebebbington:use-deno2
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from 35 commits
Commits
Show all changes
42 commits
Select commit
Hold shift + click to select a range
bc16527
chore: Convert to Deno
ebebbington ad914aa
Merge branch 'master' into use-deno2
ebebbington 3198a15
Handle duplicate modify events for watcher
ebebbington 819868f
Remove fmt from scripts
ebebbington 2f82977
Cast stylesheet in CSSTemplate.ts
ebebbington 306eb48
Use native Deno way of formatting diagnostics
ebebbington ffb7af1
Merge branch 'master' into use-deno2
ebebbington c6a7022
fix compile.ts and src imports
ebebbington 0423c8d
add example of using destiny with node TMP
ebebbington 85ebccd
im sorry ok okku
ebebbington c19747d
update examples, add browser example
ebebbington 3360ced
use crumpets
ebebbington c24c328
remove files that were added in the merge, but not present in master.…
ebebbington a8bba7d
few fixes
ebebbington 951a647
Fix examples and watch
ebebbington e80958e
move examples imports into its own file to reduce dep tree
ebebbington ab230c8
dont use ws server when watching
ebebbington 082abc7
Merge branch 'master' into use-deno2
ebebbington ccaedba
improve deno examples
ebebbington 3647b7f
make some internal code adjustments to account for some minor problem…
ebebbington f46807e
add workflow
ebebbington fd7a0dd
add bumper workflow
ebebbington c81cb90
remove loggin
ebebbington 2538f28
deno lint
ebebbington 4461918
remove dead code
ebebbington 018454f
correct compile.ts
ebebbington 8d5c29f
correct examples readme
ebebbington ff241b1
fix .d.ts file extensions
ebebbington bf2ffaa
Update crumpets
ebebbington ac08c06
once again, i am sorry okku
ebebbington 7782dc0
just for you okku
ebebbington 60525bd
okku.includes(good suggestions) // true
ebebbington a947c79
move tsconfig into its own file
ebebbington 2d0fbdf
1:1 with master
ebebbington 56adfaa
remove package-lock.json
ebebbington 9369184
fixes nd remove hack
ebebbington efe1455
cleanup readme
ebebbington 4179ddf
Merge branch 'master' of https://github.com/ebebbington/destiny into …
ebebbington 6bf424e
rm examples dir
ebebbington c034870
fmt
ebebbington 34a35b8
tidy up
ebebbington b815a53
correct workflow
ebebbington File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file was deleted.
Oops, something went wrong.
This file was deleted.
Oops, something went wrong.
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,26 @@ | ||
name: bumper | ||
on: | ||
schedule: | ||
- cron: '0 0 * * 0' | ||
|
||
jobs: | ||
update-dep: | ||
runs-on: ubuntu-latest | ||
steps: | ||
- uses: actions/checkout@v2 | ||
|
||
- name: Install Deno | ||
uses: denolib/setup-deno@master | ||
|
||
- name: Update Build Deps | ||
run: | | ||
deno run --allow-net --allow-read --allow-write https://deno.land/x/dmm/mod.ts update | ||
|
||
- name: Create Pull Request | ||
uses: peter-evans/create-pull-request@v3 | ||
with: | ||
token: ${{ secrets.CI_USER_PAT }} # TODO This needs to be a personal access token on the GH user eg Okku | ||
commit-message: Update dependencies | ||
title: Update dependencies | ||
body: This was auto-generated by GitHub Actions. | ||
branch: update-dependencies |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,51 @@ | ||
name: master | ||
|
||
on: | ||
pull_request: | ||
branches: | ||
- master | ||
push: | ||
branches: | ||
- master | ||
|
||
jobs: | ||
tests: | ||
runs-on: ubuntu-latest | ||
steps: | ||
- uses: actions/checkout@v2 | ||
|
||
- name: Install Deno | ||
uses: denolib/setup-deno@master | ||
|
||
- name: Deno version | ||
run: echo deno --version | ||
|
||
- name: Check Any Type Errors | ||
run: deno cache src/mod.ts | ||
|
||
- name: Can Compile To Dist | ||
run: npm run compile # mainly to check if there are any errors when running this command | ||
|
||
- name: Basic Example Can Be Compiled | ||
run: | | ||
cd examples/deno | ||
deno bundle --config tsconfig.json components/App.ts components/app.js | ||
cd ../node | ||
npm i | ||
node_modules/.bin/webpack --config webpack.config.js | ||
cd ../browser | ||
echo "No build step so no testing here" | ||
|
||
linter: | ||
runs-on: ubuntu-latest | ||
steps: | ||
- uses: actions/checkout@v2 | ||
|
||
- name: Install Deno | ||
uses: denolib/setup-deno@master | ||
|
||
- name: Formatter | ||
run: echo "Is this something we want?" #deno fmt --check --ignore=dist | ||
|
||
- name: Linter | ||
run: npm run lint |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,36 @@ | ||
// transpile.ts | ||
import { Crumpets } from "./deps.ts"; | ||
|
||
const compilerOptions = (JSON.parse(Deno.readTextFileSync("./tsconfig.json"))).compilerOptions | ||
|
||
async function compile( | ||
rootFile: string, | ||
) { | ||
const crumpet = new Crumpets({ | ||
rootFile, | ||
compilerOptions, | ||
filenameReplaceOptions: { | ||
search: "/src/", | ||
replacer: "/dist/", | ||
}, | ||
}); | ||
|
||
await crumpet.run(); | ||
} | ||
|
||
async function watch() { | ||
const crumpets = new Crumpets({ | ||
rootFile: "./src/mod.ts", | ||
directoryToWatch: "./src", | ||
compilerOptions, | ||
}); | ||
await crumpets.watch() | ||
} | ||
|
||
await Promise.all([ | ||
"./src/mod.ts", | ||
"./src/examples_mod.ts", | ||
].map(compile)); | ||
if (Deno.args.includes("--watch")) { | ||
await watch(); | ||
} |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1 @@ | ||
export { Crumpets } from "https://deno.land/x/[email protected]/mod.ts"; |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,3 @@ | ||
node/package-lock.json | ||
node/public | ||
node/node_modules |
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Purely making a note here so I remember to remove the
examples
directory - would be great if we could turn these into tutorials :)There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yeah honestly the examples don't make a ton of sense as part of the lib core, but that's where I run the tests, so I don't know if it's feasible to remove the examples completely 😬
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It was more to help both us understand if it works for each environment :) After all we could turn the 'setups' into written tutorials
though i see what you mean...might be worth something to you, just maybe there's a better place to put these directories?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I might've actually misunderstood what you meant, my bad. Ignore my previous comment.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
resolving, pr desc now includes a note about this