Context & Response #114
Merged
Context & Response #114
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This fixes an issue where the connection or channel would be closed before NotifyClose is setup. That can cause the monitorAndWait to block even when a connection or channel is actually closed. This happens because the consumers or publishers can close the channel due to an error inside their respective goroutines. This fix also avoids starting and leaking a bunch of goroutines inside monitorAndWait.
This enables a request to be canceled when it's context is canceled. Perhaps due to an external timeout. This also removes the chanSendWaitTime in favor of a context cancel. When a user sets a shorter deadline with a cause on the context, that cause will be returned by Send when the method returns.
bombsimon
approved these changes
Dec 7, 2024
akarl
force-pushed
the
graceful-client
branch
from
eb9c9dc to
9107c50
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
context.Done()and merging error and response chan on the request.monitorAndWaitwas properly setup.