Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Client gracefully stops #115

Merged
merged 1 commit into from
Dec 11, 2024
Merged

Client gracefully stops #115

merged 1 commit into from
Dec 11, 2024

Conversation

akarl
Copy link
Collaborator

@akarl akarl commented Dec 9, 2024

This ensures that when the client wants to stop it will ensure that all goroutines have stopped.

@akarl akarl marked this pull request as ready for review December 9, 2024 15:32
@akarl akarl requested a review from bombsimon December 9, 2024 15:32
Copy link
Member

@bombsimon bombsimon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

Just a nit on when/where to increment but also I suspect a missing defer decrementing too early which might need adjusting.

client.go Outdated Show resolved Hide resolved
client.go Show resolved Hide resolved
client.go Show resolved Hide resolved
This ensures that when the client wants to stop it will ensure that all
goroutines have stopped.
@akarl akarl merged commit 83d63e8 into master Dec 11, 2024
2 checks passed
@akarl akarl deleted the graceful-client branch December 11, 2024 14:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants