fix extension loading error in chrome extension #97
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi @0x6b , very thank you for developing this extension, I used it a lot in Firefox.
But after I switch to Brave browser (chrome-based), it's a long waited for its chrome version.
So when I see #50 closed, this extension has been ported to chrome, I can't wait to build it by myself.
Follow #95's instruction, I've built it successfully, but I met some error when I loading this extension.
So I try to fix these errors and now it worked perfectly!
This pull request fix these errors, which almost all are path issue, except the last one, which is permission issue.
In order to dynamically remove hosts permission, we need to create "optional_permissions" key and move "<all_urls>" into that key. see: https://developer.chrome.com/docs/extensions/reference/permissions/#step-2-declare-optional-permissions-in-the-manifest