error: this expression creates a reference which is immediately dereferenced by the compiler --> sink/src/events/vote_cast.rs:67:37 | 67 | ... &account.id(), | ^^^^^^^^^^^^^ help: change this to: `account.id()` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow = note: `-D clippy::needless-borrow` implied by `-D warnings` = help: to override `-D warnings` add `#[allow(clippy::needless_borrow)]`

this expression creates a reference which is immediately dereferenced by the compiler: sink/src/events/vote_cast.rs#L68

error: this expression creates a reference which is immediately dereferenced by the compiler --> sink/src/events/vote_cast.rs:68:37 | 68 | ... &proposal.id(), | ^^^^^^^^^^^^^^ help: change this to: `proposal.id()` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow

the borrowed expression implements the required traits: sink/src/kg/client.rs#L456

error: the borrowed expression implements the required traits --> sink/src/kg/client.rs:456:72 | 456 | let bolt_data = match serde_value_to_bolt(serde_json::to_value(&relation.attributes())?) { | ^^^^^^^^^^^^^^^^^^^^^^ help: change this to: `relation.attributes()` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrows_for_generic_args = note: `-D clippy::needless-borrows-for-generic-args` implied by `-D warnings` = help: to override `-D warnings` add `#[allow(clippy::needless_borrows_for_generic_args)]`

the borrowed expression implements the required traits: sink/src/kg/client.rs#L504

error: the borrowed expression implements the required traits --> sink/src/kg/client.rs:504:72 | 504 | let bolt_data = match serde_value_to_bolt(serde_json::to_value(&node.attributes())?) { | ^^^^^^^^^^^^^^^^^^ help: change this to: `node.attributes()` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrows_for_generic_args

question mark operator is useless here: sink/src/kg/client.rs#L537

error: question mark operator is useless here --> sink/src/kg/client.rs:537:9 | 537 | / Ok(self.neo4j 538 | | .execute(query) 539 | | .await? 540 | | .next() ... | 545 | | }) 546 | | .transpose()?) | |__________________________^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_question_mark = note: `-D clippy::needless-question-mark` implied by `-D warnings` = help: to override `-D warnings` add `#[allow(clippy::needless_question_mark)]` help: try removing question mark and `Ok()` | 537 ~ self.neo4j 538 + .execute(query) 539 + .await? 540 + .next() 541 + .await? 542 + .map(|row| { 543 + tracing::info!("Row: {:?}", row.to::<neo4rs::Node>()); 544 + Ok::<_, DatabaseError>(Node::<T>::try_from(row.to::<neo4rs::Node>()?)?) 545 + }) 546 + .transpose() |

question mark operator is useless here: sink/src/kg/client.rs#L553

error: question mark operator is useless here --> sink/src/kg/client.rs:553:9 | 553 | / Ok(self.neo4j 554 | | .execute(query) 555 | | .await? 556 | | .into_stream_as::<neo4rs::Node>() ... | 561 | | .try_collect::<Vec<_>>() 562 | | .await?) | |____________________^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_question_mark help: try removing question mark and `Ok()` | 553 ~ self.neo4j 554 + .execute(query) 555 + .await? 556 + .into_stream_as::<neo4rs::Node>() 557 + .map_err(DatabaseError::from) 558 + .and_then(|neo4j_node| async move { 559 + Ok(Node::<T>::try_from(neo4j_node)?) 560 + }) 561 + .try_collect::<Vec<_>>() 562 + .await |

question mark operator is useless here: sink/src/kg/client.rs#L605

error: question mark operator is useless here --> sink/src/kg/client.rs:605:9 | 605 | / Ok(self.neo4j 606 | | .execute(query) 607 | | .await? 608 | | .next() ... | 612 | | }) 613 | | .transpose()?) | |__________________________^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_question_mark help: try removing question mark and `Ok()` | 605 ~ self.neo4j 606 + .execute(query) 607 + .await? 608 + .next() 609 + .await? 610 + .map(|row| { 611 + Ok::<_, DatabaseError>(Relation::<T>::try_from(row.to::<neo4rs::Relation>()?)?) 612 + }) 613 + .transpose() |

question mark operator is useless here: sink/src/kg/client.rs#L654

error: question mark operator is useless here --> sink/src/kg/client.rs:654:9 | 654 | / Ok(self.neo4j 655 | | .execute(query) 656 | | .await? 657 | | .into_stream_as::<neo4rs::Relation>() ... | 662 | | .try_collect::<Vec<_>>() 663 | | .await?) | |____________________^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_question_mark help: try removing question mark and `Ok()` | 654 ~ self.neo4j 655 + .execute(query) 656 + .await? 657 + .into_stream_as::<neo4rs::Relation>() 658 + .map_err(DatabaseError::from) 659 + .and_then(|neo4j_rel| async move { 660 + Ok(Relation::<T>::try_from(neo4j_rel)?) 661 + }) 662 + .try_collect::<Vec<_>>() 663 + .await |

stable / clippy

Clippy has exited with exit code 101

stable / test: api/src/main.rs#L89

unused variable: `v`

stable / test: api/src/main.rs#L97

unused variable: `t`

stable / test

The process '/home/runner/.cargo/bin/cargo' failed with exit code 101

stable / fmt

ubuntu-latest pipelines will use ubuntu-24.04 soon. For more details, see https://github.com/actions/runner-images/issues/10636

stable / fmt: api/src/lib.rs#L1

Diff in /home/runner/work/kg-node/kg-node/api/src/lib.rs