Pass embedding model by ref

0xPlaygrounds · Nov 30, 2024 · 7ff68e2 · 7ff68e2
1 parent 6410809
commit 7ff68e2
Show file tree

Hide file tree

Showing 2 changed files with 2 additions and 2 deletions.
diff --git a/rig-sqlite/examples/vector_search_sqlite.rs b/rig-sqlite/examples/vector_search_sqlite.rs
@@ -43,7 +43,7 @@ async fn main() -> Result<(), anyhow::Error> {
     .await?;
 
     // Initialize SQLite vector store
-    let mut vector_store = SqliteVectorStore::new(conn, model.clone()).await?;
+    let mut vector_store = SqliteVectorStore::new(conn, &model).await?;
 
     // Add embeddings to vector store
     match vector_store.add_documents(embeddings).await {

diff --git a/rig-sqlite/src/lib.rs b/rig-sqlite/src/lib.rs
@@ -20,7 +20,7 @@ pub struct SqliteVectorStore<E: EmbeddingModel> {
 }
 
 impl<E: EmbeddingModel> SqliteVectorStore<E> {
-    pub async fn new(conn: Connection, embedding_model: E) -> Result<Self, VectorStoreError> {
+    pub async fn new(conn: Connection, embedding_model: &E) -> Result<Self, VectorStoreError> {
         // Run migrations or create tables if they don't exist
         let dims = embedding_model.ndims();
         conn.call(move |conn| {