Skip to content

Commit

Permalink
Merge pull request #39 from 0xPlaygrounds/docs/pr-template
Browse files Browse the repository at this point in the history
docs(github): implements pull request templates
  • Loading branch information
cvauclair authored Oct 3, 2024
2 parents 0065921 + f169b1b commit efeea6c
Show file tree
Hide file tree
Showing 5 changed files with 141 additions and 8 deletions.
Original file line number Diff line number Diff line change
@@ -1,23 +1,35 @@
---
name: Bug report
about: Create a report to help us improve
title: ''
title: 'bug: <title>'
labels: bug
assignees: ''

---

**Describe the bug**
- [ ] I have looked for existing issues (including closed) about this

## Bug Report
<!--
A clear and concise description of what the bug is.
--->

**To Reproduce**
## Reproduction
<!--
Code snippet.
--->

**Expected behavior**
## Expected behavior
<!--
A clear and concise description of what you expected to happen.
--->

**Screenshots**
## Screenshots
<!--
If applicable, add screenshots to help explain your problem.
--->

**Additional context**
## Additional context
<!--
Add any other context about the problem here.
--->
4 changes: 2 additions & 2 deletions .github/ISSUE_TEMPLATE/feature-or-improvement-request.md
Original file line number Diff line number Diff line change
@@ -1,8 +1,8 @@
---
name: Feature or improvement request
about: Suggest an idea for this project
title: ''
labels: ''
title: 'feat: <title>'
labels: feat
assignees: ''

---
Expand Down
37 changes: 37 additions & 0 deletions .github/PULL_REQUEST_TEMPLATE/new-model-provider.md
Original file line number Diff line number Diff line change
@@ -0,0 +1,37 @@
---
name: New model provider
about: Suggest a new model provider to integrate
title: 'feat: Add support for X'
labels: feat, model
assignees: ''

---

# New model provider: <Model Provider Name>

## Description

Please describe the model provider you are adding to the project. Include links to their website and their api documentation.

Fixes # (issue)

## Testing

Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce your results.

- [ ] Test A
- [ ] Test B

## Checklist:

- [ ] My code follows the style guidelines of this project
- [ ] I have commented my code, particularly in hard-to-understand areas
- [ ] I have made corresponding changes to the documentation
- [ ] My changes generate no new warnings
- [ ] I have added tests that prove my fix is effective or that my feature works
- [ ] New and existing unit tests pass locally with my changes
- [ ] I've reviewed the provider API documentation and implemented the types of response accurately

## Notes

Any notes you wish to include about the nature of this PR (implementation details, specific questions, etc.)
39 changes: 39 additions & 0 deletions .github/PULL_REQUEST_TEMPLATE/new-vector-store.md
Original file line number Diff line number Diff line change
@@ -0,0 +1,39 @@
---
name: Vector store integration request
about: Suggest a new vector store to integrate
title: 'feat: Add support for X vector store'
labels: data store, feat
assignees: ''

---

# New vector store: <Vector Store Name>

## Description

Please describe the vector store you are adding to the project. Include links to their website and their api documentation.

Fixes # (issue)

## Testing

Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce your results.

- [ ] Test A
- [ ] Test B

## Checklist:

- [ ] My code follows the style guidelines of this project
- [ ] I have performed a self-review of my own code
- [ ] I have commented my code, particularly in hard-to-understand areas
- [ ] I have made corresponding changes to the documentation
- [ ] My changes generate no new warnings
- [ ] I have added tests that prove my fix is effective or that my feature works
- [ ] New and existing unit tests pass locally with my changes
- [ ] Any dependent changes have been merged and published in downstream modules
- [ ] I've reviewed the vector store API documentation and implemented the types of response accurately

## Notes

Any notes you wish to include about the nature of this PR (implementation details, specific questions, etc.)
45 changes: 45 additions & 0 deletions .github/PULL_REQUEST_TEMPLATE/other.md
Original file line number Diff line number Diff line change
@@ -0,0 +1,45 @@
---
name: General pull request
about: Makes a change to the code base
title: ''
labels: ''
assignees: ''

---

# <Pull Request Title>

## Description

Please include a summary of the changes and the related issue. Please also include relevant motivation and context. List any dependencies that are required for this change.

Fixes # (issue)

## Type of change

Please delete options that are not relevant.

- [ ] Bug fix
- [ ] New feature
- [ ] Breaking change
- [ ] Documentation update

## Testing

Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce your results.

- [ ] Test A
- [ ] Test B

## Checklist:

- [ ] My code follows the style guidelines of this project
- [ ] I have commented my code, particularly in hard-to-understand areas
- [ ] I have made corresponding changes to the documentation
- [ ] My changes generate no new warnings
- [ ] I have added tests that prove my fix is effective or that my feature works
- [ ] New and existing unit tests pass locally with my changes

## Notes

Any notes you wish to include about the nature of this PR (implementation details, specific questions, etc.)

0 comments on commit efeea6c

Please sign in to comment.