Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feat(integration test): MongoDB #126

Merged
merged 15 commits into from
Dec 3, 2024
Merged

Feat(integration test): MongoDB #126

merged 15 commits into from
Dec 3, 2024

Conversation

marieaurore123
Copy link
Contributor

Uses testcontainers to create an integration test which validates vector searching with rig on a local mongodb instance.

0xMochan
0xMochan approved these changes Nov 27, 2024
View reviewed changes
Copy link
Contributor

@0xMochan 0xMochan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great! testcontainer is really straightforward. I would clarify somewhere that a docker service does need to be running for the integration test to work!

cvauclair
cvauclair requested changes Nov 28, 2024
View reviewed changes
rig-mongodb/src/lib.rs Show resolved Hide resolved
@marieaurore123 marieaurore123 changed the title feat: add integration test for mongo Feat: Add integration test for MongoDB Dec 2, 2024
@marieaurore123 marieaurore123 changed the title Feat: Add integration test for MongoDB Feat(integration test): MongoDB Dec 2, 2024
@marieaurore123 marieaurore123 merged commit 49e7191 into main Dec 3, 2024
4 checks passed
@github-actions github-actions bot mentioned this pull request Dec 3, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cvauclair cvauclair cvauclair requested changes

@0xMochan 0xMochan 0xMochan approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@marieaurore123 @cvauclair @0xMochan