-
Notifications
You must be signed in to change notification settings - Fork 323
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: groq integration #263
feat: groq integration #263
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Mainly would want you to reuse the openai
's Message
struct as it'll vastly improve a future rebase on top of my #199 PR (merging soon). Reusing more structs, the better. Reusing CompletionResponse
is max but not always possible!
Nevermind, Groq doesn't support I've tested that it works locally both in the |
@0xMochan have the requested changes been addressed? This PR looks pretty ready to me |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good, ready to merge!
Fixes #145
An attempt was made to use the
openai
provider module but it looks like each provider module'sCompletionModel
struct is dependent on each provider's client module rather than a trait, which makes refactoring slightly more complicated.