Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feat(embeddings): Add embeddable trait to embeddings builder #64

Merged
merged 23 commits into from
Oct 21, 2024
Merged

Feat(embeddings): Add embeddable trait to embeddings builder #64

merged 23 commits into from
Oct 21, 2024

Conversation

marieaurore123
Copy link
Contributor

@marieaurore123 marieaurore123 commented Oct 18, 2024 •
edited
Loading

This PR deals with the EmbeddingsBuilder.

  • The builder now only handles items that implement the Embeddable trait.
  • The builder contains documents of type (T: Embeddable, OneOrMany<String>)

All examples using the embeddings builder had to be changed as well.

@marieaurore123
fix: add embedding_docs to embeddable tool
8739692
@marieaurore123
Merge branch 'feat(embeddings)/derive-macro' into feat(embeddings)/ad…
aca9134 
…d-embeddable-trait-to-embeddings-builder
@marieaurore123
Merge branch 'feat(embeddings)/derive-macro' into feat(embeddings)/ad…
e218cf4 
…d-embeddable-trait-to-embeddings-builder
@marieaurore123
fix: fix issues caused by merge of derive macro branch
5897e22
@marieaurore123
fix: fix cargo toml of lancedb and mongodb
2477af8
@marieaurore123
Merge branch 'feat(embeddings)/derive-macro' into feat(embeddings)/ad…
23336dc 
…d-embeddable-trait-to-embeddings-builder
@marieaurore123
feat: add OneOrMany to in memory vector store
763c364
@marieaurore123
style: cargo fmt
3c5e59d
@marieaurore123
fix: update embeddingsbuilder import path
dc332c3
@marieaurore123
tests: add tests for embeddingsbuilder
db2ec98
@marieaurore123
clippy: add is empty method
3bb2231
@marieaurore123
fix: add feature flag to examples in mongodb and lancedb crates
3688b78
@marieaurore123
fix: move lancedb fixtures into it's own file
db8d188
@marieaurore123
fix: add dummy main function in fextures.rs for compiler
803b792
@marieaurore123
fix: revert fixture file, remove fixtures from cargo toml examples
97775d6
@marieaurore123
fix: update fixture import in lancedb examples
05ef716
@marieaurore123 marieaurore123 changed the title Feat(embeddings)/add embeddable trait to embeddings builder Feat(embeddings): Add embeddable trait to embeddings builder Oct 21, 2024
cvauclair
cvauclair requested changes Oct 21, 2024
View reviewed changes
cvauclair
cvauclair requested changes Oct 21, 2024
View reviewed changes
Copy link
Contributor

@cvauclair cvauclair left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Found a small typo in docstring, but once that is fixed you can merge!

@marieaurore123 marieaurore123 merged commit 38ca0db into feat/embeddings-overhaul Oct 21, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cvauclair cvauclair cvauclair requested changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@marieaurore123 @cvauclair