Feat: did resolver storage #286
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vmidyllic
reviewed
Nov 28, 2024
src/iden3comm/types/protocol/auth.ts
Outdated
| @@ -89,5 +89,5 @@ export type DIDDocument = DidResolverDidDocument & { | |||
| export type VerificationMethod = DidResolverVerificationMethod & { | |||
| published?: boolean; | |||
| info?: StateInfo; | |||
| global?: RootInfo; | |||
| global?: RootInfoWithProof; | |||
There was a problem hiding this comment.
can't we just add proof field as option and don't create another type? because we can end up with a lot of types
| @@ -219,7 +221,8 @@ export class OnChainZKPVerifier implements IOnChainZKPVerifier { | |||
| return new Map<string, ZeroKnowledgeProofResponse[]>().set(txnHash, zkProofResponses); | |||
| } | |||
|
|
|||
| public async prepareTxArgsSubmitV2( | |||
| public static async prepareTxArgsSubmitV2( | |||
| resolverUrl: string, | |||
There was a problem hiding this comment.
looks like breaking change or is is a new function?
There was a problem hiding this comment.
it is a new one, we still have prepareTxArgsSubmitV2 as an instance method
Kolezhniuk
reviewed
Nov 29, 2024
| if (!vm) { | ||
| throw new Error('Iden3StateInfo2023 verification method not found'); | ||
| } | ||
| const { global } = vm as VerificationMethod; |
There was a problem hiding this comment.
Suggested change
| const { global } = vm as VerificationMethod; | |
| const { global } = vm; |
| publishState(): Promise<string> { | ||
| throw new Error('publishState method not implemented.'); | ||
| } | ||
| publishStateGeneric(): Promise<string> { |
There was a problem hiding this comment.
please add space between functions
Kolezhniuk
approved these changes
Nov 30, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.