Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update starknet-rs to 0.13; allow deprecated methods in integration tests #689

Merged
merged 4 commits into from
Jan 23, 2025

Conversation

FabijanC
Copy link
Contributor

@FabijanC FabijanC commented Jan 23, 2025

Usage related changes

  • None, hopefully

Development related changes

  • Update the starknet-rs dependency to 0.13
    • v1 and v2 transaction methods are deprecated, so until we completely remove them or replace them with v3 counterparts, we allow deprecated methods in the integration crate.
  • Remove three TODOs, introduce one.
  • Update Argent class hash.
  • Unblock Predeclare Argent accounts #658.

Checklist:

  • Checked out the contribution guidelines
  • Applied formatting - ./scripts/format.sh
  • No linter errors - ./scripts/clippy_check.sh
  • No unused dependencies - ./scripts/check_unused_deps.sh
  • No spelling errors - ./scripts/check_spelling.sh
  • Performed code self-review
  • Rebased to the latest commit of the target branch (or merged it into my branch)
    • Once you make the PR reviewable, please avoid force-pushing
  • Updated the docs if needed - ./website/README.md
  • Linked the issues resolvable by this PR - linking info
  • Updated the tests if needed; all passing - execution info

@FabijanC FabijanC changed the title Update to starknet-rs 0.13; allow deprecated methods in integration tests Update starknet-rs to 0.13; allow deprecated methods in integration tests Jan 23, 2025
@FabijanC FabijanC merged commit a3ca720 into main Jan 23, 2025
@FabijanC FabijanC deleted the starknet-rs-0.13-allow-deprecated branch January 23, 2025 09:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants