-
Notifications
You must be signed in to change notification settings - Fork 168
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
New version: v.1.2.0 #6
Open
0xfdf
wants to merge
28
commits into
main
Choose a base branch
from
v1.1.2
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…out documentation on the methodology in the value factor
…eturns` function as well
…comes down from 68 seconds to 52 seconds on an M1 mac
…r semver, but no backwards compat violations
commit to the first implementation of ledoit-wolf
… as its own function
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Documentation improvements
New features
toraniko.main.FactorModel
, a new class that estimates the end-to-end factor model; including style scores, factor returns, rolling factor covariances and rolling asset covariances, driven by an input config fileAPI changes
Backwards compatibility with the previous version is maintained.
model._factor_returns
has been graduated to a public function (maintained under semver rules), calledmodel.factor_returns_cs
Performance enhancements
model.estimate_factor_returns
now uses the Polarsmap_groups
primitive, instead of iterating through the dates using a for loop. this significantly improved estimation speed: on a universe of 2000 assets estimated daily over 10 years, the total wall clock time went from ~64 seconds to ~44 seconds, on average, on a 2022 M1 MBP.Project/maintenance improvements
.github/ISSUE_TEMPLATE
directory.__version__
to the root__init__
(should have been there from the start)show_versions()
function has been added to root__init__
to help with diagnostics (credited Polars and @ritchie46 in the code, because it comes substantially from the Polars implementation)