-
Notifications
You must be signed in to change notification settings - Fork 20
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feat v2/get all balances #228
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code looks good but the solution don't follow code conventions of the sdk
The idea is for cosmos and emv handlers to expose same method getTokenBalances
, please move this service functions inside the handler of each chain
src/services/getCosmosBalances.ts
Outdated
}); | ||
}); | ||
} catch (error) { | ||
// |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
left to return empty array
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
After the try-catch block, it returns cosmosBalances
, which is an empty array by default:
const cosmosBalances: CosmosBalance[] = [];
Description
Add methods to get EVM and Cosmos token balances.
Type of change
Checklist: