Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: use a different rpc url for each chain #230

Merged
merged 5 commits into from
Oct 26, 2023
Merged

fix: use a different rpc url for each chain #230

merged 5 commits into from
Oct 26, 2023

Conversation

genaroibc
Copy link
Contributor

Description

Use the correct rpc url for each chain

Type of change

  • Bug fix (non-breaking change which fixes an issue)

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules

jmdev3
jmdev3 reviewed Oct 26, 2023
View reviewed changes
src/index.ts Show resolved Hide resolved
jmdev3
jmdev3 requested changes Oct 26, 2023
View reviewed changes
Copy link
Contributor

@jmdev3 jmdev3 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

left some comments, also remove the use of CHAINS_WITHOUT_MULTICALL_RPC_URLS and consume rpc always from config

@jmdev3 jmdev3 merged commit 53bfa60 into main Oct 26, 2023
5 checks passed
@jmdev3 jmdev3 deleted the fix/chain-rpc-url branch October 26, 2023 14:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jmdev3 jmdev3 jmdev3 requested changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@genaroibc @jmdev3