Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: parse undefined memo sent from api #237

Merged
merged 2 commits into from
Nov 1, 2023
Merged

Conversation

odcey
Copy link
Contributor

@odcey odcey commented Nov 1, 2023

Description

Setting memo to empty string if it's coming as "undefined" from our api
To fix the bug where amino converter "toAmino" is using omitDefault(memo) that throws an error if memo is undefined

@odcey odcey requested a review from nnoln November 1, 2023 14:53
@odcey odcey merged commit 6d42fdd into main Nov 1, 2023
5 checks passed
@odcey odcey deleted the fix/handle-undefined-memo branch November 1, 2023 15:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants