Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: remove balance check before executing route #347

Merged
merged 4 commits into from
Dec 3, 2024
Merged

chore: remove balance check before executing route #347

merged 4 commits into from
Dec 3, 2024

Conversation

odcey
Copy link
Contributor

@odcey odcey commented Dec 3, 2024 •
edited
Loading

Goal: Remove balance check before route execution - avoid RPC rate limiting

The wallet is already doing a balance check

  • add new param to route execution: bypassBalanceChecks

jmdev3
jmdev3 approved these changes Dec 3, 2024
View reviewed changes
Copy link
Contributor

@jmdev3 jmdev3 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

genaroibc
genaroibc approved these changes Dec 3, 2024
View reviewed changes
src/handlers/evm/index.ts Outdated Show resolved Hide resolved
@odcey odcey merged commit 9334ea0 into main-v2 Dec 3, 2024
4 of 5 checks passed
@odcey odcey deleted the chore/remove-balance-check branch December 3, 2024 14:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@genaroibc genaroibc genaroibc approved these changes

@jmdev3 jmdev3 jmdev3 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@odcey @jmdev3 @genaroibc