Skip to content

Commit

Permalink
RN-191: added isLargeRoom prop to the HMSRoom object (#1306)
Browse files Browse the repository at this point in the history
# Description

* added isLargeRoom prop to the HMSRoom object

### Pre-launch Checklist

- [x] The [Documentation] is updated accordingly, or this PR doesn't
require it.
- [x] I have updated the `ExampleAppChangelog.txt` file with relevant
changes.
- [x] I updated/added relevant documentation (doc comments with `///`).
- [x] I listed at least one issue that this PR fixes in the description
above.
- [x] I added new tests to check the change I am making, or this PR is
test-exempt.
- [x] All existing and new tests are passing.

<!-- Links -->
[Documentation]: https://www.100ms.live/docs
  • Loading branch information
ygit authored Jan 2, 2024
1 parent cd21c50 commit cac4632
Show file tree
Hide file tree
Showing 12 changed files with 296 additions and 273 deletions.
2 changes: 1 addition & 1 deletion .trunk/trunk.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -11,7 +11,7 @@ lint:
- [email protected]
- [email protected]
- [email protected]
- [email protected].44
- [email protected].50
- [email protected]
- [email protected]
- [email protected]
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -144,6 +144,8 @@ object HMSDecoder {
room.putInt("peerCount", it)
}
}

room.putBoolean("isLargeRoom", hmsRoom.isLargeRoom)
}
return room
}
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -1900,6 +1900,9 @@ class HMSRNSDK(
"hlsRecordingState" -> {
data.putMap("hlsRecordingState", HMSDecoder.getHMSHlsRecordingState(hmsRoom.hlsRecordingState))
}
"isLargeRoom" -> {
data.putBoolean("isLargeRoom", hmsRoom.isLargeRoom)
}
}

return data
Expand Down
2 changes: 1 addition & 1 deletion packages/react-native-hms/example/android/Gemfile.lock
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,7 @@ GEM
artifactory (3.0.15)
atomos (0.1.3)
aws-eventstream (1.3.0)
aws-partitions (1.875.0)
aws-partitions (1.876.0)
aws-sdk-core (3.190.1)
aws-eventstream (~> 1, >= 1.3.0)
aws-partitions (~> 1, >= 1.651.0)
Expand Down
2 changes: 1 addition & 1 deletion packages/react-native-hms/example/ios/Gemfile.lock
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,7 @@ GEM
artifactory (3.0.15)
atomos (0.1.3)
aws-eventstream (1.3.0)
aws-partitions (1.875.0)
aws-partitions (1.876.0)
aws-sdk-core (3.190.1)
aws-eventstream (~> 1, >= 1.3.0)
aws-partitions (~> 1, >= 1.651.0)
Expand Down
108 changes: 54 additions & 54 deletions packages/react-native-hms/example/package-lock.json

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 2 additions & 0 deletions packages/react-native-hms/ios/HMSDecoder.swift
Original file line number Diff line number Diff line change
Expand Up @@ -81,6 +81,8 @@ class HMSDecoder: NSObject {
}
}
data["peers"] = peers

data["isLargeRoom"] = room.isLarge

return data
}
Expand Down
3 changes: 3 additions & 0 deletions packages/react-native-hms/ios/HMSRNSDK.swift
Original file line number Diff line number Diff line change
Expand Up @@ -1281,6 +1281,9 @@ class HMSRNSDK: HMSUpdateListener, HMSPreviewListener {
case "hlsRecordingState":
return ["hlsRecordingState": HMSDecoder.getHlsRecordingState(hmsRoom.hlsRecordingState)]

case "isLargeRoom":
return ["isLargeRoom": hmsRoom.isLarge]

default:
return nil
}
Expand Down
Loading

0 comments on commit cac4632

Please sign in to comment.