Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feat/on leave callback reason #1247

Merged
merged 34 commits into from
Oct 30, 2023
Merged

Feat/on leave callback reason #1247

merged 34 commits into from
Oct 30, 2023

Conversation

stanwolverine
Copy link
Contributor

@stanwolverine stanwolverine commented Oct 25, 2023 •
edited
Loading

Description

  • Added reason param to onLeave callback prop of HMSPrebuilt component
  • Handled ON_ERROR event and HMSConfig related error effectively

Pre-launch Checklist

  • The Documentation is updated accordingly, or this PR doesn't require it.
  • I updated/added relevant documentation (doc comments with ///).
  • I listed at least one issue that this PR fixes in the description above.
  • I added new tests to check the change I am making, or this PR is test-exempt.
  • All existing and new tests are passing.

@stanwolverine
fix(prebuilt): 🐛 showing indicator on browser recording initialising …
e1839a3 
…state
@stanwolverine
feat(prebuilt): ✨ added lower remote peer hand ui option in participa…
439f50e 
…nts list
@stanwolverine
Merge branch 'feat/lower-remote-hand-prebuilt' into feat/error-dialog…
d7bdc3e 
…ue-ui
@stanwolverine
initial changes
61c2753
@stanwolverine
Merge branch 'develop' into feat/error-dialogue-ui
42fc289
@stanwolverine
refactoring and using useStartRecording hook
9a7c850
@stanwolverine
Merge branch 'develop' into feat/error-dialogue-ui
84aad78
@stanwolverine
refactor(sdk): ♻️ removed emitRequiredKeysError calls on ios sdk
57ddedc
@stanwolverine
refactor(sdk): ♻️ removed emitRequiredKeysError calls on android sdk
54c964d 
and renamed `emitHMSSuccess` and `emitHMSMessageSuccess` methods
@stanwolverine
refactor(sdk): ♻️ removed ON_ERROR emit code from HMSRNSDK constructor
2378fa0
@stanwolverine
feat(prebuilt): added notification for exception and api rejections
0b355c4
@stanwolverine
refactor(sdk): ♻️ removed ON_ERROR emit code from join method
6281e66
@stanwolverine
add notification on ON_ERROR event when user is inside meeting
2f936a4
@stanwolverine
removed temp code
e38cbfb
@stanwolverine
released sample app version 2.3.88 (339) ⚛️
a8c9b40
@stanwolverine
refactor(prebuilt): ♻️ extracted LeaveRoom and EndRoom modals out of …
ff6a0ba 
…`HMSManageLeave` component
@stanwolverine
feat(prebuilt): ✨ added "Leave" button on HMSExceptionNotification
0831736
@stanwolverine
released sample app version 2.3.89 (340) ⚛️
c9b98c7
@stanwolverine
Merge branch 'develop' into feat/error-dialogue-ui
a5dfdba
@stanwolverine
feat(prebuilt): ✨ added option to handle android back button press
9b9a9b4 
when enabled, back button press will open leave modal instead of leaving meeting without confirmation
@stanwolverine
feat(example-app): ✨ usage of handleBackButton prop in `HMSPrebuilt…
cd6ea86 
…` component
@stanwolverine
feat(prebuilt): ✨ added option to handle auto enter pip mode
886d5be
@stanwolverine
feat(example-app): ✨ usage of autoEnterPipMode prop in `HMSPrebuilt…
3a08d36 
…` component
@stanwolverine
Merge branch 'feat/error-dialogue-ui' into feat/added-autoenterpipmod…
7f59bb4 
…e-config-option
@stanwolverine
Merge branch 'develop' into feat/added-autoenterpipmode-config-option
641259e
@stanwolverine
released sample app version 2.3.92 (343) ⚛️
46bbc71
@stanwolverine
Merge branch 'develop' into feat/handle-back-button-press
28cadb1
@stanwolverine
Merge branch 'feat/handle-back-button-press' into feat/added-autoente…
1495d61 
…rpipmode-config-option
@stanwolverine
feat(prebuilt): ✨ added 'reason' param to onLeave callback prop of …
948aebd 
…HMSPrebuilt component
@stanwolverine
refactor(prebuilt): exported types
acdc2fe
@stanwolverine stanwolverine requested a review from ygit October 25, 2023 17:26
@stanwolverine stanwolverine self-assigned this Oct 25, 2023
@stanwolverine stanwolverine marked this pull request as ready for review October 27, 2023 18:40
@ygit ygit merged commit 473b198 into develop Oct 30, 2023
@ygit ygit deleted the feat/on-leave-callback-reason branch October 30, 2023 13:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ygit ygit ygit approved these changes

Assignees

@stanwolverine stanwolverine

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@stanwolverine @ygit