Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feat/hls player resolution state #1248

Merged
merged 30 commits into from
Oct 30, 2023
Merged

Conversation

stanwolverine
Copy link
Contributor

Description

Added hls player resolution state in sdk zustand store

Pre-launch Checklist

  • The Documentation is updated accordingly, or this PR doesn't require it.
  • I updated/added relevant documentation (doc comments with ///).
  • I listed at least one issue that this PR fixes in the description above.
  • I added new tests to check the change I am making, or this PR is test-exempt.
  • All existing and new tests are passing.

and renamed `emitHMSSuccess` and `emitHMSMessageSuccess` methods
when enabled, back button press will open leave modal instead of leaving meeting without confirmation
@stanwolverine stanwolverine requested a review from ygit October 26, 2023 09:09
@stanwolverine stanwolverine self-assigned this Oct 26, 2023
@stanwolverine stanwolverine changed the base branch from main to develop October 26, 2023 09:09
@stanwolverine stanwolverine marked this pull request as draft October 26, 2023 09:13
@ygit ygit marked this pull request as ready for review October 30, 2023 12:58
Copy link
Member

@ygit ygit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ygit ygit merged commit a43bc2a into develop Oct 30, 2023
@ygit ygit deleted the feat/hls-player-resolution-state branch October 30, 2023 13:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants