RN-174: tiles list stuck between pages on orientation change #1287
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
stanwolverine
added a commit
that referenced
this pull request
Dec 19, 2023
* updated package versions * RN-138: Implement Header & Footer hide animation (#1280) * added landscape mode support * landscape mode fixes * updated Example app changelog * inset chat view landscape mode fixes - increased height of chatlist - useFooterHeight gives correct footer height in landscape mode * released sample app version 2.3.115 (365) ⚛️ * removed portrait lock from iOS app * updated app version * updated landscape handling * released sample app version 2.3.116 (366) ⚛️ * updated packages * formatted with trunk * fix(sdk): 🐛 screenshare publishing issue due to auto enter pip * landscape bugfixes * released sample app version 2.3.117 (367) ⚛️ * version locked react-native-reanimated to 3.4.2 * inset local peer tile landscape fixes * released sample app version 2.3.119 (369) ⚛️ * fix(prebuilt): 🐛 removed `useAnimatedKeyboard` hook usage from android It was causing various issues RN-164, RN-168 * released sample app version 2.3.120 (370) ⚛️ * fix(prebuilt): 🐛 publishing screenshare resolution is reverted in landscape mode * released sample app version 2.3.121 (371) ⚛️ * updated status bar * released sample app version 2.3.122 (372) ⚛️ * initial gesture changes * feat(prebuilt): completed hide header and footer animation * released sample app version 2.3.123 (373) ⚛️ * updated packages * fix(prebuilt): 🐛 app crash on scree tap * released sample app version 2.3.124 (374) ⚛️ * fix(prebuilt): 🐛 proper fix for app crash on screen tap --------- Co-authored-by: Yogesh Singh <[email protected]> Co-authored-by: ygit <[email protected]> * RN-174: iOS Flatlist height not responsive on orientation change (#1285) * added landscape mode support * landscape mode fixes * updated Example app changelog * inset chat view landscape mode fixes - increased height of chatlist - useFooterHeight gives correct footer height in landscape mode * released sample app version 2.3.115 (365) ⚛️ * removed portrait lock from iOS app * updated app version * updated landscape handling * released sample app version 2.3.116 (366) ⚛️ * updated packages * formatted with trunk * fix(sdk): 🐛 screenshare publishing issue due to auto enter pip * landscape bugfixes * released sample app version 2.3.117 (367) ⚛️ * version locked react-native-reanimated to 3.4.2 * inset local peer tile landscape fixes * released sample app version 2.3.119 (369) ⚛️ * fix(prebuilt): 🐛 removed `useAnimatedKeyboard` hook usage from android It was causing various issues RN-164, RN-168 * released sample app version 2.3.120 (370) ⚛️ * fix(prebuilt): 🐛 publishing screenshare resolution is reverted in landscape mode * released sample app version 2.3.121 (371) ⚛️ * updated status bar * released sample app version 2.3.122 (372) ⚛️ * initial gesture changes * feat(prebuilt): completed hide header and footer animation * released sample app version 2.3.123 (373) ⚛️ * updated packages * fix(prebuilt): 🐛 app crash on scree tap * released sample app version 2.3.124 (374) ⚛️ * fix(prebuilt): 🐛 proper fix for app crash on screen tap * feat(prebuilt): disable editing username if passed as prebuilt option * fix(prebuilt): 🐛 modal hiding behind keyboard * released sample app version 2.3.125 (375) ⚛️ * added checks for safe area * fix(prebuilt): 🐛 Empty local peer tile action sheet * fix(prebuilt): 🐛 footer buttons not detecting tap when any modal closed recently * refactor(prebuilt): modal keyboard handling in android * fix(prebuilt): 🐛 participants sheet safe area fixes * released sample app version 2.3.126 (376) ⚛️ * streaming and recording bugfixes * released sample app version 2.3.128 (378) ⚛️ * stopped emitting error when rejecting the promise (#1282) * recording button states fixes * released sample app version 2.3.129 (379) ⚛️ * released sample app version 2.3.129 (379) ⚛️ * using flatlist from react-native-reanimated package * added key prop to regular tiles flatlist * fix(prebuilt): 🐛 hmssdk instance config not available when creating instance due to race condition * fix(prebuilt): 🐛 flatlist taking more than window height when orientation changes * removed key prop passed to regular tiles flatlist * updated max height * removed flatlist maxheight from android * updated reanimated version --------- Co-authored-by: Yogesh Singh <[email protected]> Co-authored-by: ygit <[email protected]> * Added Vale Linter (#1283) * added landscape mode support * landscape mode fixes * updated Example app changelog * inset chat view landscape mode fixes - increased height of chatlist - useFooterHeight gives correct footer height in landscape mode * released sample app version 2.3.115 (365) ⚛️ * removed portrait lock from iOS app * updated app version * updated landscape handling * released sample app version 2.3.116 (366) ⚛️ * updated packages * formatted with trunk * fix(sdk): 🐛 screenshare publishing issue due to auto enter pip * landscape bugfixes * released sample app version 2.3.117 (367) ⚛️ * version locked react-native-reanimated to 3.4.2 * inset local peer tile landscape fixes * released sample app version 2.3.119 (369) ⚛️ * fix(prebuilt): 🐛 removed `useAnimatedKeyboard` hook usage from android It was causing various issues RN-164, RN-168 * released sample app version 2.3.120 (370) ⚛️ * fix(prebuilt): 🐛 publishing screenshare resolution is reverted in landscape mode * released sample app version 2.3.121 (371) ⚛️ * updated status bar * released sample app version 2.3.122 (372) ⚛️ * initial gesture changes * feat(prebuilt): completed hide header and footer animation * released sample app version 2.3.123 (373) ⚛️ * updated packages * fix(prebuilt): 🐛 app crash on scree tap * released sample app version 2.3.124 (374) ⚛️ * fix(prebuilt): 🐛 proper fix for app crash on screen tap * feat(prebuilt): disable editing username if passed as prebuilt option * fix(prebuilt): 🐛 modal hiding behind keyboard * released sample app version 2.3.125 (375) ⚛️ * added checks for safe area * fix(prebuilt): 🐛 Empty local peer tile action sheet * fix(prebuilt): 🐛 footer buttons not detecting tap when any modal closed recently * refactor(prebuilt): modal keyboard handling in android * fix(prebuilt): 🐛 participants sheet safe area fixes * released sample app version 2.3.126 (376) ⚛️ * streaming and recording bugfixes * released sample app version 2.3.128 (378) ⚛️ * stopped emitting error when rejecting the promise (#1282) * recording button states fixes * released sample app version 2.3.129 (379) ⚛️ * released sample app version 2.3.129 (379) ⚛️ * using flatlist from react-native-reanimated package * added key prop to regular tiles flatlist * added Vale linter * added vale yml * updated Gridview --------- Co-authored-by: Jatin Nagar <[email protected]> * released sample app version 2.3.130 (380) ⚛️ * released sample app version 2.3.131 (381) ⚛️ * released sample app version 2.3.132 (382) ⚛️ * updated app versions * released sample app version 2.3.132 (382) ⚛️ * RN-179: Added lottie splash screen on ios (#1286) * added lottie splash screen on ios app * updated background color --------- Co-authored-by: Yogesh Singh <[email protected]> * RN-174: tiles list stuck between pages on orientation change (#1287) * fix(prebuilt): 🐛 flatlist stuck between 2 pages on orientation change * released sample app version 2.3.136 (386) ⚛️ --------- Co-authored-by: ygit <[email protected]> Co-authored-by: Yogesh Singh <[email protected]> * updated peerdependency of room kit package --------- Co-authored-by: Jatin Nagar <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Sometimes when orientation changes regular tiles list is stuck b/w 2 pages
Pre-launch Checklist
///).