Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

RN-191: added isLargeRoom prop to the HMSRoom object #1306

Merged
merged 2 commits into from
Jan 2, 2024
Merged

RN-191: added isLargeRoom prop to the HMSRoom object #1306

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
02bdab0
updated packages
ygit Jan 2, 2024
b912fee
added isLargeRoom prop to the HMSRoom object
ygit Jan 2, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .trunk/trunk.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,7 +11,7 @@ lint:
- [email protected]
- [email protected]
- [email protected]
- [email protected].44
- [email protected].50
- [email protected]
- [email protected]
- [email protected]
Expand Down
2 changes: 2 additions & 0 deletions packages/react-native-hms/android/src/main/java/com/reactnativehmssdk/HMSDecoder.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -144,6 +144,8 @@ object HMSDecoder {
room.putInt("peerCount", it)
}
}

room.putBoolean("isLargeRoom", hmsRoom.isLargeRoom)
}
return room
}
Expand Down
3 changes: 3 additions & 0 deletions packages/react-native-hms/android/src/main/java/com/reactnativehmssdk/HMSRNSDK.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1900,6 +1900,9 @@ class HMSRNSDK(
"hlsRecordingState" -> {
data.putMap("hlsRecordingState", HMSDecoder.getHMSHlsRecordingState(hmsRoom.hlsRecordingState))
}
"isLargeRoom" -> {
data.putBoolean("isLargeRoom", hmsRoom.isLargeRoom)
}
}

return data
Expand Down
2 changes: 1 addition & 1 deletion packages/react-native-hms/example/android/Gemfile.lock
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,7 @@ GEM
artifactory (3.0.15)
atomos (0.1.3)
aws-eventstream (1.3.0)
aws-partitions (1.875.0)
aws-partitions (1.876.0)
aws-sdk-core (3.190.1)
aws-eventstream (~> 1, >= 1.3.0)
aws-partitions (~> 1, >= 1.651.0)
Expand Down
2 changes: 1 addition & 1 deletion packages/react-native-hms/example/ios/Gemfile.lock
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,7 @@ GEM
artifactory (3.0.15)
atomos (0.1.3)
aws-eventstream (1.3.0)
aws-partitions (1.875.0)
aws-partitions (1.876.0)
aws-sdk-core (3.190.1)
aws-eventstream (~> 1, >= 1.3.0)
aws-partitions (~> 1, >= 1.651.0)
Expand Down
108 changes: 54 additions & 54 deletions packages/react-native-hms/example/package-lock.json
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 2 additions & 0 deletions packages/react-native-hms/ios/HMSDecoder.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -81,6 +81,8 @@ class HMSDecoder: NSObject {
}
}
data["peers"] = peers

data["isLargeRoom"] = room.isLarge

return data
}
Expand Down
3 changes: 3 additions & 0 deletions packages/react-native-hms/ios/HMSRNSDK.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1281,6 +1281,9 @@ class HMSRNSDK: HMSUpdateListener, HMSPreviewListener {
case "hlsRecordingState":
return ["hlsRecordingState": HMSDecoder.getHlsRecordingState(hmsRoom.hlsRecordingState)]

case "isLargeRoom":
return ["isLargeRoom": hmsRoom.isLarge]

default:
return nil
}
Expand Down
Loading