Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: pull in changes from internal repo #7

Merged
merged 3 commits into from
Nov 14, 2024
Merged

Conversation

adam-azarchs
Copy link
Member

  • Add support for path mapping
  • Fix handling of an edge case in parsing SPDX license expressions
  • Fix handling of conda archives which don't have an info/files

The basic idea with path mapping is that rather than execute an action
with input/output paths that look like

    bazel-out/k8-fastbuild-abc123/bin

which combines the build mode, architecture, and a hash of the
configuration state, have the action executing in the sandbox (or remote
execution) use a path like

    bazel-out/cfg/bin

Very frequently (including in the conda installer rule) that path is the
only difference between the actions executing for different
configurations, so doing that mapping means that it can share the action
cache key between several target configurations, improving cache hit
rates and therefore load on the remote execution service.

See bazelbuild/bazel#22658 for further
details, both on why it's useful and why it required these changes.
Handle cases where the same license appears on both sides of an AND
expression, e.g. `MIT and (MIT or Apache-2.0)`.
Apparently it's possible for an archive to have only info/paths.json.
@adam-azarchs adam-azarchs merged commit 7399b32 into main Nov 14, 2024
2 checks passed
@adam-azarchs adam-azarchs deleted the azarchs/merges branch November 14, 2024 06:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant