This repository has been archived by the owner on Jun 26, 2023. It is now read-only.
work around for the create_function deprecation #8
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tott
reviewed
Dec 3, 2019
| $fun = create_function('', $function); | ||
| $value = $fun(); | ||
|
|
||
| $fun = function($function) { |
There was a problem hiding this comment.
i feel we should not define the variable as this would allow calling $fun outside of this context. can we just
$value = eval( $function );
instead to keep it anonymous.
There was a problem hiding this comment.
Yes, that should work just fine as well
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of the Change
This change is intended to work around the "create_function" deprecation while allowing it to work as it did before.
Alternate Designs
Other methods to resolve were not attempted/test
Benefits
Compatibility with future versions of PHP
Possible Drawbacks
It is eval'ing code without checks
Verification Process
Gained an understanding of the current setup and replicated the documented method for running code but using an anonymous function instead.
Checklist:
Applicable Issues
Changelog Entry