Fix for remote image already in disk cache, still should return buffe…

…r in output. Caused issues with on-request image optimization
11ty · Jul 30, 2024 · 29b73ae · 29b73ae
1 parent 0f6bc69
commit 29b73ae
Show file tree

Hide file tree

Showing 2 changed files with 6 additions and 3 deletions.
diff --git a/img.js b/img.js
@@ -164,12 +164,12 @@ class Image {
     return JSON.stringify(opts);
   }
 
-  getFileContents(overridePath) {
-    if(this.isRemoteUrl) {
+  getFileContents(overrideLocalFilePath) {
+    if(!overrideLocalFilePath && this.isRemoteUrl) {
       return false;
     }
 
-    let src = overridePath || this.src;
+    let src = overrideLocalFilePath || this.src;
     if(!this._contents) {
       this._contents = {};
     }

diff --git a/src/on-request-during-serve-plugin.js b/src/on-request-during-serve-plugin.js
@@ -72,6 +72,9 @@ function eleventyImageOnRequestDuringServePlugin(eleventyConfig, options = {}) {
           if(!stat) {
             throw new Error("Invalid image format.");
           }
+          if(!stat.buffer) {
+            throw new Error("Could not find `buffer` property for image.");
+          }
 
           return {
             headers: {