Ignore providers with priority 0

1200wd · Nov 28, 2024 · faabcb1 · faabcb1
1 parent ba6b5dc
commit faabcb1
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 3 deletions.
diff --git a/bitcoinlib/services/services.py b/bitcoinlib/services/services.py
@@ -112,8 +112,9 @@ def __init__(self, network=DEFAULT_NETWORK, min_providers=1, max_providers=1, pr
 
         self.providers = {}
         for p in self.providers_defined:
-            if (self.providers_defined[p]['network'] == network or self.providers_defined[p]['network'] == '') and \
-                    (not providers or self.providers_defined[p]['provider'] in providers):
+            if ((self.providers_defined[p]['network'] == network or self.providers_defined[p]['network'] == '') and \
+                    (not providers or self.providers_defined[p]['provider'] in providers)
+                    and self.providers_defined[p]['priority']):
                 self.providers.update({p: self.providers_defined[p]})
         exclude_providers_keys = {pi: self.providers[pi]['provider'] for pi in self.providers if self.providers[pi]['provider'] in exclude_providers}.keys()
         for provider_key in exclude_providers_keys:

diff --git a/tests/test_services.py b/tests/test_services.py
@@ -626,7 +626,7 @@ def test_service_network_litecoin_legacy(self):
         self.assertIn(txid, [utxo['txid'] for utxo in utxos])
 
     def test_service_blockcount(self):
-        for nw in ['bitcoin', 'litecoin', 'testnet']:
+        for nw in ['bitcoin', 'litecoin', 'testnet']:  # ToDo: add testnet4 when more providers are available
             srv = ServiceTest(min_providers=3, cache_uri='', network=nw, exclude_providers=['bitgo', 'bitaps'])
             srv.blockcount()
             n_blocks = None