Parse negative numbers in Acuant birthdays (#4178)

**Why**: these are how timestamps before the Unix epoch are encoded
18F · Sep 10, 2020 · 19ebc9c · 19ebc9c
1 parent 697dd56
commit 19ebc9c
Show file tree

Hide file tree

Showing 2 changed files with 5 additions and 1 deletion.
diff --git a/app/services/doc_auth/acuant/pii_from_doc.rb b/app/services/doc_auth/acuant/pii_from_doc.rb
@@ -30,7 +30,7 @@ def call
         hash
       end
 
-      ACUANT_TIMESTAMP_FORMAT = %r{/Date\((?<milliseconds>\d+)\)/}.freeze
+      ACUANT_TIMESTAMP_FORMAT = %r{/Date\((?<milliseconds>-?\d+)\)/}.freeze
 
       # @api private
       def convert_date(date)

diff --git a/spec/services/doc_auth/acuant/pii_from_doc_spec.rb b/spec/services/doc_auth/acuant/pii_from_doc_spec.rb
@@ -30,6 +30,10 @@
       expect(pii_from_doc.convert_date('/Date(449625600000)/')).to eq('04/01/1984')
     end
 
+    it 'parses and formats negative numbers' do
+      expect(pii_from_doc.convert_date('/Date(-985824000000)/')).to eq('10/06/1938')
+    end
+
     it 'is nil for a bad format' do
       expect(pii_from_doc.convert_date('/Foobar(111111)/')).to eq(nil)
     end