Deploy RC 373 to Production #10460
Merged
Deploy RC 373 to Production #10460
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…#10437) * `SamlIdpController#selfie_needed?` * `IdvSessionConcern#user_needs_selfie?` * OpenIdConnect::AuthorizationController#selfie_needed? * SignUp::CompletionsController#selfie_required? * ServiceProvidersession#selfie_required? (Also the null sp session) * User#identity_verified_with_selfie? changelog: Internal,code cleanup,Renamed various `selfie` methods to`biometric_comparison`, because that's what we really mean.
* add es and fr translations for email * changelog:User-Facing Improvements, Please call email, update translations * normalize yaml * update translations * lint fix for fr translations * update fr subject line
[skip changelog] This does not cause an issue because these failures are empty. But when copying from them to create new yml files I discovered the key is wrong and should be fixed.
…eStep` (#10448) The `add_cost` and `add_costs` methods both create `SpCost` records for `FlowStateMachine` steps that inherit from `Idv::Steps::DocAuthBaseStep`. We [removed the `FlowStateMachine`](#8705) from all paths that lead to the creation of an `SpCost` record about a year ago. The [`FlowStateMachine`](https://github.com/18F/identity-idp/blob/main/app/services/flow/flow_state_machine.rb) and associated [`Idv::Steps::DocAuthBaseStep`](https://github.com/18F/identity-idp/blob/main/app/services/idv/steps/doc_auth_base_step.rb) remain, however, to support the in-person flow. The in-person flow does not create `SpCost` records in the `FlowStateMachine`. These methods, like many methods in `FlowStateMachine` relics, are unused. We left these unused methods because it was assumed that the `FlowStateMachine` would be entirely removed from the in-person flow shortly after it was removed from the unsupervised flow. That has not been the case so this commit does some cleanup to remove them. [skip changelog]
* Remove unused remember_created_at user column changelog: Internal, Database, Remove unused column from users table * Remove user ignored_columns for dropped field
changelog: Bug Fixes, Spam Mitigation, Allow form submission when reCAPTCHA fails to load
changelog: Internal, Doc Auth, Fix typo of portrait.
…pts (#10438) * LG-12178: new event name of idv_selfie_image_clicked and captureAttempts. changelog: Internal, Doc Auth, Update analytics event for selfie image clicked. * LG-12178: fix test. * LG-12178: event name. * LG-12178: add captureAttempts to all click events. * LG-12178: add captureAttempts to event. * LG-12178: add captureAttempts to event. * LG-12178: adjust param order
* changelog: Upcoming Features, Auth, Migration for password compromised check * fix schema from merge conflict * reword migration to follow naming convention * reshake migration
In #10390 we started using the new `idv_session.updated_user_address` value to represent the user address if it is present. This allows us to stop overwriting the user address that was on the document in `pii_from_doc`. We were not able to actually take this step because of the 50/50 state issues related to session updates. This commit stops overwriting the PII from the document in `pii_from_doc` when a new address is provided in `Idv::AddressController` [skip changelog]
changelog: Bug Fixes, Components, Fix flash of accordion content during page load
mitchellhenke
requested review from
aduth,
night-jellyfish,
mdiarra3,
jmax-gsa,
jmhooper and
a team
zachmargolis
approved these changes
Apr 18, 2024
jmax-gsa
approved these changes
Apr 18, 2024
night-jellyfish
approved these changes
Apr 18, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
User-Facing Improvements
Bug Fixes
Internal
selfiemethods tobiometric_comparison, because that's what we really mean. (#10437)Upcoming Features