Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Lg-14277 verification data analytics event #11509

Merged
merged 16 commits into from
Nov 27, 2024
Merged

Lg-14277 verification data analytics event #11509

merged 16 commits into from
Nov 27, 2024

Conversation

AShukla-GSA
Copy link
Contributor

🎫 Ticket

Link to the relevant ticket:
LG-14277

🛠 Summary of changes

Logging socure request and response metrics described in ticket.

@AShukla-GSA AShukla-GSA requested a review from amirbey November 18, 2024 20:34
@AShukla-GSA AShukla-GSA requested a review from amirbey November 19, 2024 22:50
@voidlily
Copy link
Contributor

hi, do you mind rebasing your branch? there were some changes to reviewapps that are making this PR not run properly in the reviewapp environment

@voidlily
Copy link
Contributor

it also seems like you may have 2 copies of reviewapps running for this PR, let me know when you do finish rebasing so i can just go in and clean those up

solipet
solipet reviewed Nov 22, 2024
View reviewed changes
Copy link
Contributor

@solipet solipet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking great! A few small comments.

app/services/analytics_events.rb Outdated Show resolved Hide resolved
app/jobs/socure_docv_results_job.rb Show resolved Hide resolved
app/services/analytics_events.rb Outdated Show resolved Hide resolved
@AShukla-GSA AShukla-GSA force-pushed the lg-14277-verification-data-analytics-event branch from 021a8fc to 215f44a Compare November 25, 2024 20:27
@AShukla-GSA AShukla-GSA force-pushed the lg-14277-verification-data-analytics-event branch from 7e7eb6e to 8b23a73 Compare November 26, 2024 19:44
@amirbey amirbey self-requested a review November 27, 2024 02:22
@AShukla-GSA AShukla-GSA force-pushed the lg-14277-verification-data-analytics-event branch from 8b23a73 to 1c17789 Compare November 27, 2024 15:03
@AShukla-GSA AShukla-GSA merged commit 23f509e into main Nov 27, 2024
2 checks passed
@AShukla-GSA AShukla-GSA deleted the lg-14277-verification-data-analytics-event branch November 27, 2024 15:17
@matthinz matthinz mentioned this pull request Dec 3, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@amirbey amirbey amirbey approved these changes

@theabrad theabrad Awaiting requested review from theabrad

@jmax-gsa jmax-gsa Awaiting requested review from jmax-gsa

@solipet solipet Awaiting requested review from solipet

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@AShukla-GSA @voidlily @amirbey @solipet