-
Notifications
You must be signed in to change notification settings - Fork 113
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
LG-14813 default users requiring facial match to LN #11531
base: main
Are you sure you want to change the base?
Conversation
changelog: Upcoming Features, IdV Socure, default users requiring facial match to LN
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
@@ -6,8 +6,16 @@ module DocAuthVendorConcern | |||
|
|||
# @returns[String] String identifying the vendor to use for doc auth. | |||
def doc_auth_vendor | |||
bucket = ab_test_bucket(:DOC_AUTH_VENDOR) | |||
if resolved_authn_context_result.facial_match? && default_vendor_is_not_mock? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
could we have mock, lexisnexis and socure enabled at the same time. what if a facial match is required and the default vendor is :mock? would a user be routed to a vendor that does not support facial match? 🤔
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
yeah, say default is socure and facial match is requested. Maybe:
bucket = ab_test_bucket(:DOC_AUTH_VENDOR
if resolved_authn_context_result.facial_match? && bucket != :mock
bucket = :lexis_nexus
end
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
furthering Doug's point ... this appears to assume that mock or lexis nexis is enabled as a doc auth vendor. It seems that we'd need to know whether a vendor is enabled before routing to that vendor. what happens if only socure is enabled, would we have a doc auth vendor when a facial match is req'd 🤔
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
yeah, say default is socure and facial match is requested. Maybe:
bucket = ab_test_bucket(:DOC_AUTH_VENDOR if resolved_authn_context_result.facial_match? && bucket != :mock bucket = :lexis_nexus end
We want to bypass A/B test bucketing if facial match is required.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
furthering Doug's point ... this appears to assume that mock or lexis nexis is enabled as a doc auth vendor. It seems that we'd need to know whether a vendor is enabled before routing to that vendor. what happens if only socure is enabled, would we have a doc auth vendor when a facial match is req'd 🤔
If LN is not enabled should we just redirect them to an error page?
let(:idv_vendor) { Idp::Constants::Vendors::LEXIS_NEXIS } | ||
context 'when doc_auth_vendor is Lexis Nexis' do | ||
let(:idv_vendor) { Idp::Constants::Vendors::LEXIS_NEXIS } |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
thanks 🙏🏿
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
what if mock is default vendor and facial match is req'd? do we have testing for this?
@@ -56,9 +56,13 @@ | |||
{} | |||
end | |||
let(:idv_vendor) { Idp::Constants::Vendors::MOCK } | |||
let(:vot) { 'P1' } |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Vectors of Trust is deprecated and slated to be removed. 😢
🎫 Ticket
Link to the relevant ticket:
LG-14813
🛠 Summary of changes
If a user is going through IdV with a Service Provider requiring facial match, we want to default them to Lexis Nexis and not have them go through Socure.
📜 Testing Plan
Provide a checklist of steps to confirm the changes.
doc_auth_vendor_default: 'socure'
in application.yml