Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add time in stopwatch when the note is added #22

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

kharisisriyant
Copy link

If user click add notes when the stopwatch is running, it will also track when the note is added. One of the use case is when I take a break and create a notes to track when I take a break, or if I want to record milestones of the task and when I achieved it.

I think it is a good feature, but maybe one of the concern is if user restart the watch, should the time in notes deleted?

@1995YogeshSharma
Copy link
Owner

The idea behind feature is good.
Also, you mentioned the catch I had in my mind (restarting the clock).

I think one solution is to log the current desktop time instead of stopwatch time.

retHtmlBody += "<li class='row list-group-item'>" +
"<p class='col-md-11 list-item'>" +
watch.notes[i] +
watch.notes[i] + " (" + GiveTimeString(watch.notesTime[i]) + ") " +
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think '[' would be better than '('

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants