Skip to content
This repository has been archived by the owner on Jun 27, 2018. It is now read-only.

Added the ability to pass text and URL parameters to the Outcome #15

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

bryceott
Copy link

@bryceott bryceott commented Nov 18, 2016

Lets optional 'text' and 'url' outcome parameters be written back to the LMS, as is supported by Canvas (not sure how well this is supported by other LMSes).

@spvickers
Copy link
Contributor

As this is not part of the IMS specification it will probably only work with Canvas-based tool consumers. I think it would be better to either use the Result service (if a comment field is required) or to add a separate Canvas-specific service to minimise any confusion with what should be expected to work for all tool consumers.

@bryceott
Copy link
Author

@spvickers I'm quite confident you have a better understanding of this codebase than I do :), so what you're saying makes a lot of sense, although inclusion of the parameters here is of course option.

At any rate, I'm happy to try and modify this to work better with the existing structure if you don't mind giving me some more direction (ie: similar examples, etc). Let me know your thoughts. I've got a working Canvas integration I can develop and test against, but not really anything for other LMSes at the moment.

@spvickers
Copy link
Contributor

We are looking at whether the code should be refactored in some way, and one area which had not been considered in the past is the ease of adding in bespoke services which lie outside the specification. Perhaps it is just a matter of subclassing to create a Canvas specific variation, etc? Ideas welcome.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants