Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

perf: optimize embed mode #2331

Merged

Conversation

qianphong
Copy link
Contributor

What this PR does / why we need it?

When embedding with http://localhost:3000/ui/chat/{token}?mode=embed into a third party, there should be no space left in the top right corner. The position of the history button is incorrect. I expect the display to be optimized for standalone embedding.

Summary of your change

I've added a route parameter ?mode=embed&popup=no to determine whether the content is displayed in a popup. There is no impact on the Floating Mode.

1739964046754

<!-- before -->
http://localhost:3000/ui/chat/{token}?mode=embed
<!-- after -->
http://localhost:3000/ui/chat/{token}?mode=embed&popup=no

Please indicate you've done the following:

  • Made sure tests are passing and test coverage is added if needed.
  • Made sure commit message follow the rule of Conventional Commits specification.
  • Considered the docs impact and opened a new docs issue or PR with docs changes if needed.

Copy link

f2c-ci-robot bot commented Feb 19, 2025

Adding the "do-not-merge/release-note-label-needed" label because no release-note block was detected, please follow our release note process to remove it.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Copy link

f2c-ci-robot bot commented Feb 19, 2025

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@shaohuzhang1 shaohuzhang1 merged commit 4df183c into 1Panel-dev:main Feb 20, 2025
1 check was pending
@qianphong qianphong deleted the perf/embed-mode-optimization branch February 20, 2025 04:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants