Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: 修改默认pip安装包路径 #964

Merged
merged 1 commit into from
Aug 13, 2024
Merged

ci: 修改默认pip安装包路径 #964

merged 1 commit into from
Aug 13, 2024

Conversation

shaohuzhang1
Copy link
Contributor

ci: 修改默认pip安装包路径

Copy link

f2c-ci-robot bot commented Aug 12, 2024

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment


RUN chmod 755 /opt/maxkb/app/installer/run-maxkb.sh && \
cp -r /opt/maxkb/model/base/hub /opt/maxkb/model/tokenizer && \
cp -f /opt/maxkb/app/installer/run-maxkb.sh /usr/bin/run-maxkb.sh && \
cp -f /opt/maxkb/app/installer/init.sql /docker-entrypoint-initdb.d

VOLUME [ "$PIP_TARGET" ]
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

可以。

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

安装脚本需要指定这个volume,不指定的话,容器被删除后虽然不会将这个volume一起删除,但是这个volume名称是个长字符串,再想找到这个volume就要花些时间

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

在启动一个同样名字的容器会自动挂上这个卷吧?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

并不会

@liuruibin
Copy link
Member

/release-note-none

@liuruibin liuruibin merged commit 3e2e5ec into main Aug 13, 2024
4 of 5 checks passed
@liuruibin liuruibin deleted the pr@main@ci_pip_target branch August 13, 2024 03:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants