Revert X11 connection timeout handling #147
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This reverts commit efedfb9.
As shown in #133 this does not seem like feasible functionality to maintain long term because both sides (faster erroring and slower erroring) are inherently in conflict. I don't believe that
arboardshould make this choice for users. Instead, users who have specific latency concerns can wrap the call toClipboard::new()in their ownthread::spawncalls.cc @jonZlotnik as the original PR author. Do you think this prove problematic for your project, or do you anticipate a smooth move to handling this timeout wrapping in your projects code?