Add is_async switch to new_client_from_enviroment #89
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mjpieters
commented
Oct 6, 2023
| @@ -15,6 +15,7 @@ repository = "https://github.com/1Password/connect-sdk-python" | |||
| python = "^3.7" | |||
| python-dateutil = "^2.8.1" | |||
| httpx = "^0.23.3" | |||
| typing-extensions = "<4.8.0" | |||
There was a problem hiding this comment.
typing-extensions 1.4.8 drops support for Python 3.7, so the version is pinned.
mjpieters
commented
Oct 6, 2023
| @@ -3,6 +3,8 @@ | |||
| from httpx import HTTPError | |||
| import json | |||
| import os | |||
| from typing import Optional, Union, overload | |||
| from typing_extensions import Literal | |||
There was a problem hiding this comment.
typing.Literal was added in Python 3.8, which is why we need the backported version here.
If this project were to drop support for 3.7, the import could be updated.
|
Happy to drop this PR if / when #92 is merged. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change makes it possible to use
new_client_from_enviroment()and stillselect between async and sync clients based on the current codebase.
The change includes the type hints needed for type checkers to know what kind
of object is returned in what circumstances; e.g.
This makes working with the library a lot easier in IDEs with type checker
support as they now know what exact methods a client supports.
This fixes #84