-
Notifications
You must be signed in to change notification settings - Fork 102
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Revert "Revert "Merge pull request #82 from 1Password/jane/undefined-…
…to-null"" This reverts commit 08769e5.
- Loading branch information
CerulanLumina
authored and
CerulanLumina
committed
Apr 13, 2023
1 parent
08769e5
commit 43f2775
Showing
7 changed files
with
11 additions
and
11 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,6 +1,6 @@ | ||
/** This is a comment. */ | ||
export type Colors = | ||
| { type: "Red", content?: undefined } | ||
| { type: "Blue", content?: undefined } | ||
| { type: "Red", content: null } | ||
| { type: "Blue", content: null } | ||
| { type: "Green", content: string }; | ||
|
2 changes: 1 addition & 1 deletion
2
core/data/tests/can_generate_algebraic_enum_with_skipped_variants/output.ts
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,4 +1,4 @@ | ||
export type SomeEnum = | ||
| { type: "A", content?: undefined } | ||
| { type: "A", content: null } | ||
| { type: "C", content: number }; | ||
|
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,9 +1,9 @@ | ||
/** This struct has a unit field */ | ||
export interface StructHasVoidType { | ||
thisIsAUnit: undefined; | ||
thisIsAUnit: null; | ||
} | ||
|
||
/** This enum has a variant associated with unit data */ | ||
export type EnumHasVoidType = | ||
| { type: "hasAUnit", content: undefined }; | ||
| { type: "hasAUnit", content: null }; | ||
|
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters